Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong Variable Name #8753

Closed
modxbot opened this issue Sep 22, 2012 · 2 comments
Closed

Wrong Variable Name #8753

modxbot opened this issue Sep 22, 2012 · 2 comments
Labels
area-core bug The issue in the code or project, which should be addressed.

Comments

@modxbot
Copy link
Contributor

modxbot commented Sep 22, 2012

leffyrant created Redmine issue ID 8753

Lines 21-24 of this particular Processor are:

$canRemove = $this->processEventResponse($OnBeforeUserFormDelete);
if (!empty($*canRemove*)) {
    return $modx->error->failure($*canSave*);
}

So, you see that although the response is stored in the "canRemove" variable, the potential failure message contains variable "canSave".
@modxbot
Copy link
Contributor Author

modxbot commented Oct 2, 2012

Eiventeleiron submitted:

Pull request with the fix: #398

enigmatic-user pushed a commit to enigmatic-user/revolution that referenced this issue Feb 13, 2014
[modxcms#8753] fixing that trivial variable error.
008c041
enigmatic-user pushed a commit to enigmatic-user/revolution that referenced this issue Feb 13, 2014
@opengeek
[modxcms#8753] Fix variable name in security/user/removemultiple proc…
ab4bf38 
…essor

Merge remote-tracking branch 'Evengard/rel22bug8753' into bug-8753

* Evengard/rel22bug8753:
  [modxcms#8753] fixing that trivial variable error.
enigmatic-user pushed a commit to enigmatic-user/revolution that referenced this issue Feb 13, 2014
@opengeek
MODX Revolution 2.2.5-pl
8608c05 
Merge branch 'release-2.2'

* release-2.2: (130 commits)
  Bump version for 2.2.5-pl
  [modxcms#8753] fixing that trivial variable error.
  French translation update
  [modxcms#8196] Changed event type for fieldChangeEvent for combo boxes
  [modxcms#8186] Adding FC rules checking based on reloadData.
  [modxcms#8790] adding a possibility to hide the new password after changing via profile reset.
  [modxcms#7631] add changelog entry
  Fix duplicate beforeSave() in modProcessorObjectCreate
  Italian translation for Revo 2.2.5
  [modxcms#7551] adding an additional check so that the destination static file can't be an existing directory
  Czech translation update
  Correction in setting lexicon
  [modxcms#7654] Fix Update processor for ResourceGroup-restricted TVs
  Preserve backwards compatibility(add 'object' key) after objectType fix
  Last changes in the German translation for Revo 2.2.5
  [modxcms#8767] add changelog entry
  Possible fix for bug [modxcms#4430]
  [modxcms#8767] possible bug fix
  [modxcms#8545] add changelog entry
  [modxcms#8089] add changelog entry
  ...
danyaPostfactum pushed a commit to danyaPostfactum/revolution that referenced this issue Mar 26, 2014
@opengeek
Merge branch 'release-2.2' into develop
e0ff51e 
* release-2.2:
  Bump version for 2.2.5-pl
  [modxcms#8753] fixing that trivial variable error.

Conflicts:
	_build/build.sample.properties
	_build/build.xml
	core/docs/changelog.txt
	core/docs/version.inc.php
@garryn
Copy link
Member

garryn commented Jun 6, 2014

PR in the referenced ticket to fix this issue has been merged.

@garryn garryn closed this as completed Jun 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core bug The issue in the code or project, which should be addressed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garryn @modxbot