Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling drag/drop in resource tree via system settings not working #8089

Closed
modxbot opened this issue Jun 8, 2012 · 3 comments
Closed

Disabling drag/drop in resource tree via system settings not working #8089

modxbot opened this issue Jun 8, 2012 · 3 comments
Labels
bug The issue in the code or project, which should be addressed. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.
Milestone
Revolution-2.2.5-pl

Comments

@modxbot
Copy link
Contributor

modxbot commented Jun 8, 2012

itwillbeok created Redmine issue ID 8089

I tried disabling the drag'n'drop functionality in the resource tree via system settings. It had no effect, drag'n'dropping still possible.

'enable_dragdrop' is definitly set to 0, i checked several times.
@modxbot
Copy link
Contributor Author

modxbot commented Jun 8, 2012

itwillbeok submitted:

Line 16 in manager/assets/modext/widgets/resource/modx.tree.resource.js reads:

@,enableDD: !Ext.isEmpty(MODx.config.enable_dragdrop) ? true : false@

But enable_dragdrop is "0", which makes Ext.isEmpty("0") still false. So maybe it should be something like

@,enableDD: Ext.isEmpty(MODx.config.enable_dragdrop) || MODx.config.enable_dragdrop === '0' ? false : true@

@modxbot
Copy link
Contributor Author

modxbot commented Sep 4, 2012

itwillbeok submitted:

Issue still open in 2.2.4

@opengeek
Copy link
Member

opengeek submitted:

See #377

enigmatic-user pushed a commit to enigmatic-user/revolution that referenced this issue Feb 13, 2014
@rtripault
Should fix tracker issue modxcms#8089
fe85b6b
enigmatic-user pushed a commit to enigmatic-user/revolution that referenced this issue Feb 13, 2014
@opengeek
[modxcms#8089] add changelog entry
8bbb847
enigmatic-user pushed a commit to enigmatic-user/revolution that referenced this issue Feb 13, 2014
@opengeek
[modxcms#8089] Fix ability to disable drag/drop in Resource tree
01b0d9b 
Merge branch 'bug-8089' into release-2.2

* bug-8089:
  [modxcms#8089] add changelog entry
  Should fix tracker issue modxcms#8089
enigmatic-user pushed a commit to enigmatic-user/revolution that referenced this issue Feb 13, 2014
@opengeek
MODX Revolution 2.2.5-pl
8608c05 
Merge branch 'release-2.2'

* release-2.2: (130 commits)
  Bump version for 2.2.5-pl
  [modxcms#8753] fixing that trivial variable error.
  French translation update
  [modxcms#8196] Changed event type for fieldChangeEvent for combo boxes
  [modxcms#8186] Adding FC rules checking based on reloadData.
  [modxcms#8790] adding a possibility to hide the new password after changing via profile reset.
  [modxcms#7631] add changelog entry
  Fix duplicate beforeSave() in modProcessorObjectCreate
  Italian translation for Revo 2.2.5
  [modxcms#7551] adding an additional check so that the destination static file can't be an existing directory
  Czech translation update
  Correction in setting lexicon
  [modxcms#7654] Fix Update processor for ResourceGroup-restricted TVs
  Preserve backwards compatibility(add 'object' key) after objectType fix
  Last changes in the German translation for Revo 2.2.5
  [modxcms#8767] add changelog entry
  Possible fix for bug [modxcms#4430]
  [modxcms#8767] possible bug fix
  [modxcms#8545] add changelog entry
  [modxcms#8089] add changelog entry
  ...
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue in the code or project, which should be addressed. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.
Projects
None yet
Milestone
Revolution-2.2.5-pl
Development

No branches or pull requests
2 participants
@opengeek @modxbot