New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix branch for travis badge in readme #12803

Merged
merged 1 commit into from Dec 5, 2015

Conversation

Projects
None yet
2 participants
@Mark-H
Collaborator

Mark-H commented Dec 5, 2015

What does it do

The travis badge shows the build status. This was set to the develop branch, but after changing the branching strategy, this needs to be updated for the 2.x branch.

Why is it needed

Showing the accurate build status.

Related issue(s)/PR(s)

None, though while merging #12801 I noticed it was set wrong.

pixelchutes added a commit that referenced this pull request Dec 5, 2015

Merge pull request #12803 from Mark-H/fix-travis-branch
Fix branch for travis badge in readme

@pixelchutes pixelchutes merged commit 7e5f717 into modxcms:2.x Dec 5, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@pixelchutes

This comment has been minimized.

Collaborator

pixelchutes commented Dec 5, 2015

Job #309.3 - modxcms/revolution - Travis CI

$ phpunit -c ./phpunit.xml
This version of PHPUnit requires PHP 5.6; using the latest version of PHP is highly recommended.

The command "phpunit -c ./phpunit.xml" exited with 1.

Thoughts?

@pixelchutes

This comment has been minimized.

Collaborator

pixelchutes commented Dec 5, 2015

Failing on PHP 5.5 build only.

modxcms_revolution_-_travis_ci

@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Dec 5, 2015

Yeah noticed that, looks like this may contain a solution:
http://andreas.heigl.org/2015/11/12/testing-code-with-phpunit-on-travis-ci-for-php-5-5-and-php7/
Op 5 dec. 2015 6:21 p.m. schreef "Mike Reid" notifications@github.com:

Failing on PHP 5.5 build only.

[image: modxcms_revolution_-_travis_ci]
https://cloud.githubusercontent.com/assets/352182/11609099/f49f6806-9b39-11e5-96a7-580aeb76ea5d.png


Reply to this email directly or view it on GitHub
#12803 (comment).

@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Dec 5, 2015

Thanks for the quick merge by the way :)

@Mark-H Mark-H deleted the Mark-H:fix-travis-branch branch Dec 5, 2015

@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Dec 5, 2015

Pull sent to fix travis: #12804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment