#6142 Added abbility to see which plugins attached to the event #modxbughunt #13324
Conversation
…t on page with events #modxbughunt
| $c = $this->modx->newQuery('modPlugin'); | ||
| $c->leftJoin('modPluginEvent', 'modPluginEvent', 'modPluginEvent.pluginid = modPlugin.id'); | ||
| $c->sortby('modPluginEvent.priority', 'ASC'); | ||
| $c->where(['modPluginEvent.event' => $eventArray['name']]); |
There was a problem hiding this comment.
While i would love to use the short array syntax, this would break compatibility to PHP 5.3.x
There was a problem hiding this comment.
Agree, It's a hard to follow when it has become a habit. :)
|
@rtripault I thought about to add marks for plugins, like |
|
This looks useful, but can't be merged until the short array syntax is fixed ;) |
|
@Mark-H @rtripault Fixed short arrays and add statuses for plugins (see screnshot below) |
| $eventArray['plugins'] = ''; | ||
| } | ||
|
|
||
| $eventArray['plugins'] = json_encode($eventArray['plugins']); |
There was a problem hiding this comment.
What is the benefit of json encoding here and having to parse the json client side later ?
There was a problem hiding this comment.
You are right, it's obsolete. I've fixed and removed this encoding/decoding.
|
All working as expected. |
* upstream/pr/13324: Remove obsolete json encoding/decoding Added readable statuses of the plugins Fixed short array syntax for compatibility with php 5.3 #6142 Added abbility to see which plugins attached to the event on page with events #modxbughunt
|
Many thanks for your work and patience ;) |
|
#modxbughunt #1point to @rtripault |
What does it do?
It allows to see which plugins attached to system event on the events page.
Why is it needed?
When in the system a lot of plugins sometimes it can be useful so see which of them attached to events from events page. Or when we try to see which plugins work with specific event.
Related issue(s)/PR(s)
Partially fix for #6142