Fix modParser so we can output brackets around parsed elements

[JoshuaLuckers]

What does it do?

Find the position of the last occurrence of prefix in the original content so we can output brackets around parsed elements.

Why is it needed?

This way we can for example use the output as array key in a form input name.

Related issue(s)/PR(s)

#13903

[Jako]

Maybe this will break 'Mosquito' tags like [[[[*field:is=`0`:then=`!SomeScript`:else=`$SomeChunk`]]]]
described on https://modx.com/blog/2012/09/14/tags-as-the-result-or-how-conditionals-are-like-mosquitoes/, but I did not check that.

[JoshuaLuckers]

I tried the 'Mosquito' tag and it seems to work as expected:

[[[[*id:is=`1`:then=`$TestChunk`:else=`$AnotherChunk`]]]]

Content of TestChunk:

<strong>TestChunk</strong>

Content of AnotherChunk:

<strong>AnotherChunk</strong>

Output:

<strong>TestChunk</strong>

[JoshuaLuckers]

The build(s) seem to fail with this change. I will check the failures and try to fix them this weekend.

[JoshuaLuckers]

Made some changes and added some additional tests. The builds are passing.

[bezumkin]

First it was okay, but then I noticed the error.

[bezumkin]

This breaks the first parsed tag on page.

<title>[[*pagetitle]] - [[++site_name]]</title>

outputs

<title> - MODX Revolution</title>

in default template

[JoshuaLuckers]

@bezumkin thanks for noticing. Will try to find the issue later. Did you get an error in the log?

[bezumkin]

@JoshuaLuckers Yep

[2018-06-05 12:30:42] (ERROR @ /home/s12854/www/core/model/modx/modparser.class.php : 557) Could not find snippet with name pagetitle.
[2018-06-05 12:30:42] (ERROR @ /home/s12854/www/core/model/modx/modparser.class.php : 557) Could not find snippet with name pagetitle.
[2018-06-05 12:30:42] (ERROR @ /home/s12854/www/core/model/modx/modparser.class.php : 557) Could not find snippet with name pagetitle.
[2018-06-05 12:30:42] (ERROR @ /home/s12854/www/core/model/modx/modparser.class.php : 557) Could not find snippet with name [pagetitle.
[2018-06-05 12:30:42] (ERROR @ /home/s12854/www/core/model/modx/modparser.class.php : 557) Could not find snippet with name [pagetitle.
[2018-06-05 12:30:42] (ERROR @ /home/s12854/www/core/model/modx/modparser.class.php : 557) Could not find snippet with name [pagetitle.
[2018-06-05 12:30:42] (ERROR @ /home/s12854/www/core/model/modx/modparser.class.php : 557) Could not find snippet with name [pagetitle.

[JoshuaLuckers]

Found the problem. [1+1] or [something] will break the parser again.

Will try to fix it tomorrow.

[JoshuaLuckers]

Solving this issue is more complex than expected. I'm not sure if I can solve it before 2.7.0 is released.

[JoshuaLuckers]

@bezumkin I decided to use regular expressions to solve the issue. I do think it needs some more testing.
If anyone is willing to test it, please do so!

[JoshuaLuckers]

Tried it with a more complex site and I found some more issues. I will add tests to check for these issues later.

[JoshuaLuckers]

Pushed some changes that solves the issues I had. Any more testing would be appreciated.

[OptimusCrime]

All tests pass, awesome work!

[opengeek]

FYI, the site I use to test parser changes is completely broken in 2.x with or without this PR so I'm having a hard time verifying this.

[MrRoco]

Tested and working :)

Gives us possibilities with Formalicious :)

Seems the issue was resolved by the author.