Fix/remove custom xmlrss #14034
Fix/remove custom xmlrss #14034
Conversation
composer.json
Outdated
| "classmap": ["core/xpdo/"] | ||
| "classmap": [ | ||
| "core/xpdo/", | ||
| "core/model/modx" |
There was a problem hiding this comment.
I've experimented with external core and found out that MODX classes not added to autoload configuration of the composer. So maybe this PR not the best place for this change, but it should be in MODX 3 to get MODX core classes available via autoload.php.
|
❤️ |
| } | ||
| return $this->success('', array('html' => implode("\n",$o))); | ||
|
|
||
| return $this->success('', array('html' => implode(PHP_EOL, $output))); |
There was a problem hiding this comment.
Maybe use the short array syntax [] here as well?
There was a problem hiding this comment.
Looks good, thanks @alroniks. Suggestion from @JoshuaLuckers is valid and would be welcome but I'd be happy to see this merged without as well. After 2.7 when 2.x has been merged into 3.x I'd love to throw phpcs and phpcbf against the entire codebase to get all different code styles cleaned up. :D
|
@Mark-H I've removed also mentioning of xmlrss from the build configuration and replaced array by short syntax. |
|
Hi @opengeek Could we delete this files? Yes, I am asking for approve :) |
Mark-H
added
pr/ready-for-merging
|
PR is tested. Feed widgets works after |
…ibrary [#14034] * upstream/pr/14034: Array short syntax Removed xmlrss from build configuration Removed modx from classmap to avoid double required classes Using SimplePie directly in the widget Added by composer class SimplePie for parsing rss feeds Removed outdated code
What does it do?
It removes custom classes for parsing RSS feeds in dashboard widgets by replacing them SimplePie library (composer depps).
Why is it needed?
Because an original refactoring pull request is too big to review it will help to bring fixes a bit faster splitting refactoring into small pieces.
Related issue(s)/PR(s)
#13900