New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove custom xmlrss #14034

Merged
merged 6 commits into from Aug 14, 2018

Conversation

Projects
None yet
5 participants
@Alroniks
Collaborator

Alroniks commented Aug 9, 2018

What does it do?

It removes custom classes for parsing RSS feeds in dashboard widgets by replacing them SimplePie library (composer depps).

Why is it needed?

Because an original refactoring pull request is too big to review it will help to bring fixes a bit faster splitting refactoring into small pieces.

Related issue(s)/PR(s)

#13900

@Alroniks Alroniks requested review from Mark-H and opengeek as code owners Aug 9, 2018

"classmap": ["core/xpdo/"]
"classmap": [
"core/xpdo/",
"core/model/modx"

This comment has been minimized.

@Mark-H

Mark-H Aug 9, 2018

Collaborator

is this necessary here?

This comment has been minimized.

@Alroniks

Alroniks Aug 9, 2018

Collaborator

I've experimented with external core and found out that MODX classes not added to autoload configuration of the composer. So maybe this PR not the best place for this change, but it should be in MODX 3 to get MODX core classes available via autoload.php.

@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Aug 9, 2018

schermafbeelding 2018-08-09 om 17 10 22

❤️

}
return $this->success('', array('html' => implode("\n",$o)));
return $this->success('', array('html' => implode(PHP_EOL, $output)));

This comment has been minimized.

@JoshuaLuckers

JoshuaLuckers Aug 9, 2018

Contributor

Maybe use the short array syntax [] here as well?

@Mark-H

Looks good, thanks @Alroniks. Suggestion from @JoshuaLuckers is valid and would be welcome but I'd be happy to see this merged without as well. After 2.7 when 2.x has been merged into 3.x I'd love to throw phpcs and phpcbf against the entire codebase to get all different code styles cleaned up. :D

@Alroniks

This comment has been minimized.

Collaborator

Alroniks commented Aug 10, 2018

@Mark-H I've removed also mentioning of xmlrss from the build configuration and replaced array by short syntax.

@Mark-H

Mark-H approved these changes Aug 10, 2018

@Alroniks

This comment has been minimized.

Collaborator

Alroniks commented Aug 13, 2018

Hi @opengeek Could we delete this files? Yes, I am asking for approve :)

@opengeek

Please don't just change syntax (array syntax in this case) or formatting when making specific other changes like this in the future. We can apply those is atomic commits to avoid unnecessary conflicts.

@ilyautkin

This comment has been minimized.

Contributor

ilyautkin commented Aug 14, 2018

PR is tested. Feed widgets works after composer update. No bugs found.

@Alroniks Alroniks merged commit efcb5b6 into modxcms:3.x Aug 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Alroniks added a commit that referenced this pull request Aug 14, 2018

Remove outdated custom xmlrss classes and replace them by SimplePie l…
…ibrary [#14034]

* upstream/pr/14034:
  Array short syntax
  Removed xmlrss from build configuration
  Removed modx from classmap to avoid double required classes
  Using SimplePie directly in the widget
  Added by composer class SimplePie for parsing rss feeds
  Removed outdated code

@Alroniks Alroniks deleted the Alroniks:fix/remove_custom_xmlrss branch Aug 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment