Hide Input Option Values for TV types where this is useless #14040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jako
approved these changes
Aug 31, 2018
Jako
added
type-frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
The box called Input Option Values are displayed for all types of TVs. This makes no sense for a bunch of them, and hiding the box would most likely be a good idea. This PR attempts to do this.
The approach is not very good, but I found no better ways of doing while attempting to solve this. The approach is to hide the box in the renderes, and display it when a new TV type is selected. This way, we do not hide the box for third party or custom TV types.
Why is it needed?
Reasons stated above.
Related issue(s)/PR(s)
#7293