Improved messages on plugin editor page #14128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… value of system setting
alroniks
added
type-frontend
philipwhiuk
reviewed
Nov 6, 2018
Jako
approved these changes
Nov 8, 2018
|
@Mark-H Your time ;) |
Mark-H
approved these changes
Nov 8, 2018
Mark-H
added
pr/ready-for-merging
|
Looks good :) |
alroniks
added a commit
that referenced
this pull request
Nov 8, 2018
* upstream/pr/14128: Fixed grammar in the message Improved messages on plugin editor page and also fixed bug with wrong value of system setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It changes messages about disabling/enabling plugins and also fixed bug with proper determining the value of
inline_helpsystem setting. Additionally, it improves descriptions of checkboxes on the page.Why is it needed?
It is standardizing terminology a bit (at least on the one page) and also fixes some bugs that improves UX.
Related issue(s)/PR(s)
Fixes #12900