-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistency in "New" buttons on tables #14312
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jako
reviewed
Jan 27, 2019
Jako
reviewed
Jan 27, 2019
Jako
reviewed
Jan 27, 2019
Jako
reviewed
Jan 27, 2019
Jako
reviewed
Jan 27, 2019
Jako
suggested changes
Jan 27, 2019
It is nice to have consistent usage of new or create, but IMO this PR removes too much. |
In MODX there are similar in meaning, and sometimes identical lines, but different keys in translation. |
Jako
reviewed
Jan 27, 2019
Jako
reviewed
Jan 27, 2019
JoshuaLuckers
added
area-lexicons
Issues related to translations and lexicons implementation.
pr/review-needed
Pull request requires review and testing.
labels
Jan 28, 2019
@Jako Hi! Is it okay? |
Jako
approved these changes
Jan 29, 2019
Mark-H
approved these changes
Jan 29, 2019
Mark-H
added
pr/ready-for-merging
Pull request reviewed and tested and ready for merging.
and removed
pr/review-needed
Pull request requires review and testing.
labels
Jan 29, 2019
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-lexicons
Issues related to translations and lexicons implementation.
pr/ready-for-merging
Pull request reviewed and tested and ready for merging.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
I corrected the translations of the buttons for consistency:
-Access Controls
---User Groups: "New User Group" -> "New Group"
---Roles: "Create New" -> "New Role"
---Access Policies: "Add" -> "New Policy"
-Resource Groups: "Create Resource Group" -> "New Group"
-Property Sets
---Property Sets: "New Property Set" -> "New Set"
---Properties: "Create Property" -> "New Property" Under System
-Contexts: "Create New" -> "New Context"
-Actions
---Top Menu: "Create Menu" -> "New Menu"
-Package Management
---Packages: "Add New Package" -> "New Package"
---Providers: "Add New Provider" -> "New Provider"
-Content Types: "New Content Type" -> "New Type"
-Namespaces: "Create New" -> "New Namespace"
-System Settings: "Create New Setting" -> "New Setting"
I did not find the location of these buttons:
-Form Customization: "Add" -> "New Rule" Under Tools
-Lexicon Management
---Languages: "Create Language" -> "New Language"
Why is it needed?
To improve consistency within the control panel
Related issue(s)/PR(s)
#1188