Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency in "New" buttons on tables #14312

Merged
merged 3 commits into from
Jan 29, 2019
Merged

Consistency in "New" buttons on tables #14312

merged 3 commits into from
Jan 29, 2019

Conversation

Ibochkarev
Copy link
Collaborator

What does it do?

I corrected the translations of the buttons for consistency:
-Access Controls
---User Groups: "New User Group" -> "New Group"
---Roles: "Create New" -> "New Role"
---Access Policies: "Add" -> "New Policy"
-Resource Groups: "Create Resource Group" -> "New Group"
-Property Sets
---Property Sets: "New Property Set" -> "New Set"
---Properties: "Create Property" -> "New Property" Under System
-Contexts: "Create New" -> "New Context"
-Actions
---Top Menu: "Create Menu" -> "New Menu"
-Package Management
---Packages: "Add New Package" -> "New Package"
---Providers: "Add New Provider" -> "New Provider"
-Content Types: "New Content Type" -> "New Type"
-Namespaces: "Create New" -> "New Namespace"
-System Settings: "Create New Setting" -> "New Setting"

I did not find the location of these buttons:
-Form Customization: "Add" -> "New Rule" Under Tools
-Lexicon Management
---Languages: "Create Language" -> "New Language"

Why is it needed?

To improve consistency within the control panel

Related issue(s)/PR(s)

#1188

core/lexicon/en/user.inc.php Outdated Show resolved Hide resolved
@Jako
Copy link
Collaborator

Jako commented Jan 27, 2019

It is nice to have consistent usage of new or create, but IMO this PR removes too much.

@Ruslan-Aleev
Copy link
Collaborator

Ruslan-Aleev commented Jan 27, 2019

In MODX there are similar in meaning, and sometimes identical lines, but different keys in translation.
For example, new_tv | tv_new | add_tv
I have collected some duplicate (lines new, create and add, others did not look), we need to look at and delete the extra lines - lang_double.txt

@JoshuaLuckers JoshuaLuckers added area-lexicons Issues related to translations and lexicons implementation. pr/review-needed Pull request requires review and testing. labels Jan 28, 2019
@Ibochkarev
Copy link
Collaborator Author

@Jako Hi! Is it okay?

@JoshuaLuckers JoshuaLuckers self-requested a review January 29, 2019 07:51
@Mark-H Mark-H added pr/ready-for-merging Pull request reviewed and tested and ready for merging. and removed pr/review-needed Pull request requires review and testing. labels Jan 29, 2019
@Mark-H Mark-H added this to the v3.0.0-alpha milestone Jan 29, 2019
@Mark-H Mark-H self-assigned this Jan 29, 2019
@Mark-H Mark-H merged commit f908447 into modxcms:3.x Jan 29, 2019
@Ibochkarev Ibochkarev deleted the consistency-in-new-buttons branch January 29, 2019 14:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-lexicons Issues related to translations and lexicons implementation. pr/ready-for-merging Pull request reviewed and tested and ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants