Fix Stored XSS: Context #14357
Merged
Fix Stored XSS: Context #14357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaLuckers
added
area-security
pr/review-needed
|
This PR in the current form corrects the error when you edit and save context data. In the list of contexts, the error is not fixed. I take for revision. |
|
All grids in 3.x automatically get the htmlEncode renderer applied, so I'm wondering if we can ignore reports/PRs like this targeting 2.x? |
Mark-H
approved these changes
Mar 6, 2019
alroniks
approved these changes
Mar 6, 2019
alroniks
added
pr/ready-for-merging
alroniks
pushed a commit
that referenced
this pull request
Mar 6, 2019
* upstream/pr/14357: Update modx.panel.context.js Fix #14342
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fix Stored XSS: Context
Why is it needed?
Security reason
Related issue(s)/PR(s)
#14342