Protect important directories #14374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaLuckers
added
area-core
pr/review-needed
|
Thanks for taking time to create this PR and help make MODX better. It seems that you are a first-time contributor. To prevent us from merging this PR it's important that you sign the Contributor License Agreement (CLA). If you have signed the CLA already please let us know. If you have any questions feel free to post them. |
|
@JoshuaLuckers thanks for link to CLA. I have already signed today. |
alroniks
suggested changes
Feb 13, 2019
Added. |
alroniks
suggested changes
Feb 15, 2019
Jako
reviewed
Feb 15, 2019
JoshuaLuckers
approved these changes
Feb 16, 2019
Jako
approved these changes
Feb 16, 2019
Ruslan-Aleev
approved these changes
Feb 26, 2019
alroniks
reviewed
Feb 26, 2019
| * | ||
| * @return array | ||
| */ | ||
| public function getProtectedPathDirectories() { |
There was a problem hiding this comment.
Does it make sense to make it static as it returns constants? Not a request, but just a question for discussion.
alroniks
approved these changes
Feb 26, 2019
Mark-H
approved these changes
Feb 28, 2019
Mark-H
added
pr/ready-for-merging
alroniks
pushed a commit
to alroniks/revolution
that referenced
this pull request
Mar 1, 2019
* upstream/pr/14374: Fixed comment Fixed comment Removed ru lexicons for rename and delete actions Added lexicons (en, ru) for rename and delete actions Fix new directory name check in processor browser/directory/rename Fix processor description browser/directory/rename Fixed issue modxcms#14114
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Added list of protected directories, that can not be renamed or removed from manager:
Renaming or removing this directories will cause error with message "Access Denied".
Also, this PR contain 2 small fixes in processor browser/directory/rename
Why is it needed?
Description from issue:
Right click on any of these folders, rename or delete them and you are in trouble. Could also reduce impact of malicious actions by people with low morals or a short temper.Related issue(s)/PR(s)
#14114