Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes the font stack for displaying code #14427

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Changes the font stack for displaying code #14427

merged 1 commit into from
Mar 1, 2019

Conversation

Ibochkarev
Copy link
Collaborator

@Ibochkarev Ibochkarev commented Feb 26, 2019

What does it do?

Changes the font stack to display code

Why is it needed?

For more correct display of fonts to display code using native fonts.
This stack is used in the latest version of Bootstrap 4.3.x Native fonts

Change from $codefonts: "Courier New", Courier, monospace; to $codefonts: SFMono-Regular, Menlo, Monaco, Consolas, "Liberation Mono", "Courier New", monospace;

Before:
modx revolution 2019-02-26 13-19-07
After:
modx revolution 2019-02-26 13-34-56

Environment:

  • MODX 3.x
  • MacOS 10.13.6 (17G5019)
  • Google Chrome: 72.0.3626.109

Related issue(s)/PR(s)

#14415

@JoshuaLuckers JoshuaLuckers added type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript. pr/review-needed Pull request requires review and testing. labels Feb 26, 2019
@JoshuaLuckers JoshuaLuckers added this to the v3.0.0-alpha milestone Feb 26, 2019
@Mark-H Mark-H added pr/ready-for-merging Pull request reviewed and tested and ready for merging. and removed pr/review-needed Pull request requires review and testing. labels Feb 28, 2019
@JoshuaLuckers JoshuaLuckers self-assigned this Mar 1, 2019
@alroniks alroniks changed the title Changes the font stack to display code Changes the font stack for displaying code Mar 1, 2019
@alroniks alroniks merged commit 82e133f into modxcms:3.x Mar 1, 2019
alroniks pushed a commit that referenced this pull request Mar 1, 2019
* upstream/pr/14427:
  Change code font stack
@Ibochkarev Ibochkarev deleted the Code-font-change branch March 1, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/ready-for-merging Pull request reviewed and tested and ready for merging. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants