Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes the font stack for displaying code #14427

Merged
merged 1 commit into from Mar 1, 2019

Conversation

@Ibochkarev
Copy link
Contributor

commented Feb 26, 2019

What does it do?

Changes the font stack to display code

Why is it needed?

For more correct display of fonts to display code using native fonts.
This stack is used in the latest version of Bootstrap 4.3.x Native fonts

Change from $codefonts: "Courier New", Courier, monospace; to $codefonts: SFMono-Regular, Menlo, Monaco, Consolas, "Liberation Mono", "Courier New", monospace;

Before:
modx revolution 2019-02-26 13-19-07
After:
modx revolution 2019-02-26 13-34-56

Environment:

  • MODX 3.x
  • MacOS 10.13.6 (17G5019)
  • Google Chrome: 72.0.3626.109

Related issue(s)/PR(s)

#14415

@Ibochkarev Ibochkarev requested review from Mark-H and opengeek as code owners Feb 26, 2019

@Mark-H

Mark-H approved these changes Feb 28, 2019

@JoshuaLuckers JoshuaLuckers self-assigned this Mar 1, 2019

@Alroniks Alroniks changed the title Changes the font stack to display code Changes the font stack for displaying code Mar 1, 2019

@Alroniks Alroniks merged commit 82e133f into modxcms:3.x Mar 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Alroniks added a commit that referenced this pull request Mar 1, 2019

Changes the font stack for displaying code #14427
* upstream/pr/14427:
  Change code font stack

@Ibochkarev Ibochkarev deleted the Ibochkarev:Code-font-change branch Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.