Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for recently edited resources #14511

Merged
merged 4 commits into from
Sep 1, 2019
Merged

Improvements for recently edited resources #14511

merged 4 commits into from
Sep 1, 2019

Conversation

wax100
Copy link
Contributor

@wax100 wax100 commented Mar 27, 2019

What does it do?

Fix #14334 & #14333

Why is it needed?

Describe the issue you are solving.

Related issue(s)/PR(s)

#14334 & #14333

@JoshuaLuckers JoshuaLuckers added type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript. pr/review-needed Pull request requires review and testing. labels Mar 27, 2019
@JoshuaLuckers JoshuaLuckers added this to the v3.0.0-alpha milestone Mar 27, 2019
Ibochkarev
Ibochkarev previously approved these changes Mar 28, 2019
Copy link
Collaborator

@Ibochkarev Ibochkarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix solves problem #14333 and #14334 - tested. Works!
Dashboard | MODX Revolution 2019-03-28 10-16-43

@wax100 Thanks!

@JoshuaLuckers JoshuaLuckers changed the title Fixin g bugs #14334 & #14333 Improvements for recently edited resources Mar 30, 2019
igorsuhinin pushed a commit to igorsuhinin/revolution that referenced this pull request Apr 7, 2019
Mark-H
Mark-H previously approved these changes Apr 25, 2019
@Mark-H
Copy link
Collaborator

Mark-H commented Apr 25, 2019

FYI #14540 also includes this fix.

JoshuaLuckers
JoshuaLuckers previously approved these changes May 4, 2019
@sdrenth
Copy link
Contributor

sdrenth commented May 24, 2019

@wax100 Could you also add the following permission checks? I think its a neat addition to the fixes you already have done.

Because if you don't the permission "logs" you should not be able to view the view all link at the bottom, because the user has no permissions for viewing this page and will result in an "Access denied page".

Requested changes

manager/templates/default/dashboard/recentlyeditedresources.tpl

{if $modx->hasPermission('logs')}
    <div class="widget-footer">
        <a href="{$_config.manager_url}?a=system/logs">{$_lang.w_view_all} &rarr;</a>
    </div>
{/if}

webroot/manager/templates/default/dashboard/onlineusers.tpl

{if $modx->hasPermission('logs')}
    <div class="widget-footer">
        <a href="{$_config.manager_url}?a=system/logs">{$_lang.w_view_all} &rarr;</a>
    </div>
{/if}

@sdrenth
Copy link
Contributor

sdrenth commented Jun 14, 2019

@wax100 Any thought about my last comment?

@gpsietzema
Copy link
Contributor

@wax100 ? :-)

@wax100 wax100 dismissed stale reviews from JoshuaLuckers, Mark-H, and Ibochkarev via 41196a9 June 14, 2019 07:54
@wax100
Copy link
Contributor Author

wax100 commented Jun 14, 2019

@gpsietzema @sdrenth
Sorry , I did not see your comments.
And cant find branch =) so I edit online. Hope, I did it correct

@sdrenth
Copy link
Contributor

sdrenth commented Jun 28, 2019

@Mark-H Could you maybe take another look at this PR?

@alroniks
Copy link
Collaborator

@sdrenth It should be rebased before next review loop.

@sdrenth
Copy link
Contributor

sdrenth commented Jul 12, 2019

@alroniks I can't do the rebase. @wax100 Can you make sure the PR gets rebased to it can hopefully be merged in the next review loop?

@Mark-H Mark-H merged commit 737f3c6 into modxcms:3.x Sep 1, 2019
@Mark-H
Copy link
Collaborator

Mark-H commented Sep 1, 2019

The majority of this fix was already applied in the processors refactor. I've merged the conflicts which only applied the logs permission requirement into 3.x.

Thanks.

Mark-H added a commit that referenced this pull request Sep 9, 2019
…#11264]

Merge remote-tracking branch 'upstream/pr/14540' into 3.x

* upstream/pr/14540:
  Fixed issue #11264: Added checking for the specific user in the recently edited resources (regarding the comment #11264 (comment))
  Fixed issue #11264: Added date and time to the list of recently edited resources for the personal profile
  Implemented changes of pull request #14511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/review-needed Pull request requires review and testing. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants