Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for recently edited resources #14511

Open
wants to merge 1 commit into
base: 3.x
from

Conversation

Projects
None yet
5 participants
@wax100
Copy link

commented Mar 27, 2019

What does it do?

Fix #14334 & #14333

Why is it needed?

Describe the issue you are solving.

Related issue(s)/PR(s)

#14334 & #14333

@Ibochkarev
Copy link
Contributor

left a comment

This fix solves problem #14333 and #14334 - tested. Works!
Dashboard | MODX Revolution 2019-03-28 10-16-43

@wax100 Thanks!

@JoshuaLuckers JoshuaLuckers changed the title Fixin g bugs #14334 & #14333 Improvements for recently edited resources Mar 30, 2019

igorsuhinin pushed a commit to igorsuhinin/revolution that referenced this pull request Apr 7, 2019

@Mark-H

Mark-H approved these changes Apr 25, 2019

@Mark-H

This comment has been minimized.

Copy link
Collaborator

commented Apr 25, 2019

FYI #14540 also includes this fix.

@sdrenth

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

@wax100 Could you also add the following permission checks? I think its a neat addition to the fixes you already have done.

Because if you don't the permission "logs" you should not be able to view the view all link at the bottom, because the user has no permissions for viewing this page and will result in an "Access denied page".

Requested changes

manager/templates/default/dashboard/recentlyeditedresources.tpl

{if $modx->hasPermission('logs')}
    <div class="widget-footer">
        <a href="{$_config.manager_url}?a=system/logs">{$_lang.w_view_all} &rarr;</a>
    </div>
{/if}

webroot/manager/templates/default/dashboard/onlineusers.tpl

{if $modx->hasPermission('logs')}
    <div class="widget-footer">
        <a href="{$_config.manager_url}?a=system/logs">{$_lang.w_view_all} &rarr;</a>
    </div>
{/if}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.