-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for recently edited resources #14511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI #14540 also includes this fix. |
@wax100 Could you also add the following permission checks? I think its a neat addition to the fixes you already have done. Because if you don't the permission "logs" you should not be able to view the view all link at the bottom, because the user has no permissions for viewing this page and will result in an "Access denied page". Requested changesmanager/templates/default/dashboard/recentlyeditedresources.tpl
webroot/manager/templates/default/dashboard/onlineusers.tpl
|
@wax100 Any thought about my last comment? |
@wax100 ? :-) |
41196a9
@gpsietzema @sdrenth |
@Mark-H Could you maybe take another look at this PR? |
@sdrenth It should be rebased before next review loop. |
The majority of this fix was already applied in the processors refactor. I've merged the conflicts which only applied the Thanks. |
…#11264] Merge remote-tracking branch 'upstream/pr/14540' into 3.x * upstream/pr/14540: Fixed issue #11264: Added checking for the specific user in the recently edited resources (regarding the comment #11264 (comment)) Fixed issue #11264: Added date and time to the list of recently edited resources for the personal profile Implemented changes of pull request #14511
What does it do?
Fix #14334 & #14333
Why is it needed?
Describe the issue you are solving.
Related issue(s)/PR(s)
#14334 & #14333