Remove deprecated fields from modResource

[JoshuaLuckers]

What does it do?

Removes the fields from the schema and drops them from the table.

• privateweb
• privatemgr
• donthit

Why is it needed?

Fields are marked as deprecated and are no longer in use in the core.

How to test

Install/update MODX and see the columns not longer being present in the table.

Related issue(s)/PR(s)

Closes #16174

[codecov-commenter]

Codecov Report

Base: 17.95% // Head: 17.90% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (9ad5f39) compared to base (32aba73).
Patch coverage: 87.50% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@             Coverage Diff              @@
##                3.x   #16187      +/-   ##
============================================
- Coverage     17.95%   17.90%   -0.05%     
- Complexity    10442    10478      +36     
============================================
  Files           561      561              
  Lines         39051    39222     +171     
============================================
+ Hits           7010     7024      +14     
- Misses        32041    32198     +157     

Impacted Files	Coverage Δ
core/src/Revolution/modResource.php	44.56% <ø> (ø)
core/src/Revolution/modParser.php	67.28% <66.66%> (-0.11%)	⬇️
core/src/Revolution/Filters/modInputFilter.php	100.00% <100.00%> (+3.12%)	⬆️
core/src/Revolution/Processors/Context/GetList.php	57.14% <0.00%> (-17.86%)	⬇️
...Revolution/Processors/Element/Category/GetList.php	45.23% <0.00%> (-9.31%)	⬇️
core/src/Revolution/Sources/modMediaSource.php	41.63% <0.00%> (-0.22%)	⬇️
core/src/Revolution/modPhpThumb.php	0.00% <0.00%> (ø)
core/src/Revolution/Sources/modS3MediaSource.php	0.00% <0.00%> (ø)
core/src/Revolution/Processors/Source/GetList.php	0.00% <0.00%> (ø)
core/src/Revolution/Sources/modFTPMediaSource.php	0.00% <0.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[JoshuaLuckers]

I probably have to redo this, I used the GitHub "sync fork" option which did a merge instead of rebase..

[Mark-H]

Do merge commits (* that do not actually include any other commits) still matter if we squash when merging @opengeek?

[opengeek]

Do merge commits (* that do not actually include any other commits) still matter if we squash when merging @opengeek?

They matter because all of those changes become part of this PR.

[opengeek]

Or looking at it, maybe they don't? I have no idea.

[opengeek]

I'd prefer out-of-date changes to be rebased, however. And if there are no conflicts, there is no reason to do this.

[opengeek]

That said, this can be left alone. I'll deal with it when integrating it.

[JoshuaLuckers]

Ok! The UI of GitHub didn't mention the strategy used for syncing the fork, neither did it ask for confirmation 😅. Next time I'll use the CLI again.

[opengeek]

Ok! The UI of GitHub didn't mention the strategy used for syncing the fork, neither did it ask for confirmation 😅. Next time I'll use the CLI again.

I've never tried to use that other than on a clean fork. I'll do some more research, but it looks like it did a squash merge, and that's why there are no changes from the merge showing up as part of the PR. If that is the case, there may be no problem doing it that way.

[Mark-H]

I think you probably did not mean to commit setup/includes/upgrades/mysql/3.0.2-pl.php? Makes sense IMO to add this into 3.1 only.

[JoshuaLuckers]

@Mark-H yes that’s my mistake, will fix it tomorrow

[JoshuaLuckers]

@opengeek if you have time please re-review this PR!

[opengeek]

This looks good, but can someone confirm it works if the "upgrade" is re-run?