You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi!
I found this crate for the same reason you created it – I find myself using decimal rounding so often it bugs me that there is no built-in support for it, so I would check if a crate for it existed before going on and creating one myself. But, for this API to flow better with the Rust APIs, I do have some suggestions:
Use f64::powi/f32::powi to remove the limitation set by hard-coding each order of magnitude (saw that this is exactly what more freedom to round #1 suggested 3 years ago, so I'll consider this crate dead): Sorry, this was already added, I was looking at an outdated commit.
Hi!
I found this crate for the same reason you created it – I find myself using decimal rounding so often it bugs me that there is no built-in support for it, so I would check if a crate for it existed before going on and creating one myself. But, for this API to flow better with the Rust APIs, I do have some suggestions:
UseSorry, this was already added, I was looking at an outdated commit.f64::powi
/f32::powi
to remove the limitation set by hard-coding each order of magnitude (saw that this is exactly what more freedom to round #1 suggested 3 years ago, so I'll consider this crate dead):round
(f32::round() -> u32
), consider renaming it to e.g.roundf
to emphasize that the return value is a float.The text was updated successfully, but these errors were encountered: