Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why provide flag for language ? #2

Closed
mrleblanc101 opened this issue Nov 19, 2022 · 7 comments
Closed

Why provide flag for language ? #2

mrleblanc101 opened this issue Nov 19, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@mrleblanc101
Copy link

mrleblanc101 commented Nov 19, 2022

Isn't it a bit confusing and opinionated ?

Why is English the flag of Britain, that would be confusing for an American.

Same for Spanish, would be confusing for a Mexican if you use Spain flag.

What's the standard/logic behind the flag choice for the languages ?

@mrleblanc101
Copy link
Author

mrleblanc101 commented Nov 19, 2022

Apple finally got rid of the flags in the input type picker for this exact reason. It's bad practice.

Before:
image

After:
image

Here's a exemple with a Russian speaking Ukrainian that don't want to be associate with the Russian flag: https://discussions.apple.com/thread/253751126

Maybe it would be better to change the icon to a glyph like Apple or otherwise remove the Language Flag option. People can always match the flag to language manually if they like and use the correct variation for their app context. (i.e. A UK flag or a USA flag for English)

@SPiercer
Copy link

@mrleblanc101
English is originated in Britain as same as Spanish in Spain,

There's literally no difference lingual between American and British as they are both English.

the only difference can be in input types because of the keyboard layout that's all, whereas this package is not intended for input layout only.

if you want to change something feel free to fork the package and open a pull request to make those glyph icons

@mrleblanc101
Copy link
Author

mrleblanc101 commented Nov 19, 2022

A lot of language have more obscure origin, a lot of language would share the same flag too. India has 9 different languages for exemple.

Language do not have flag, why force a flag to something that hasn't one ?

With svg inlining, you could completely control/override the language flag style like this:

.language-flag {
  background: black;
  color: white;
  // or
  background: red;
  color: transparent;
  opacity: 0.5;
}

@SPiercer
Copy link

if you want to change something feel free to fork the package and open a pull request to make those glyph icons

@mrleblanc101
Copy link
Author

I won't waste my time if you're not open to the idea like you seem to be from your other comments.

Also, more thinking would need to be done. Monochrome glyph (like black background and white/transparent text) won't work with every design and since the SVG and in <img /> tag instead of being inined as <svg> element, there would be no way to style them.

@MohmmedAshraf
Copy link
Owner

@mrleblanc101 Thank you for your feedback, your opinion will be considered in the next release, i will work on it as soon as possible.

I will be closing this issue for now.

@MohmmedAshraf MohmmedAshraf added the enhancement New feature or request label Nov 19, 2022
@MohmmedAshraf MohmmedAshraf self-assigned this Nov 19, 2022
@jcc5018
Copy link

jcc5018 commented Dec 23, 2022

There's literally no difference lingual between American and British as they are both English.

There is differences between English languages when it comes to spelling. American English may have something spelled color whereas British English would be colour and many other examples. Britain's also tend to use S where Americans would use Z

Not sure is Australia has its own differences, or which it leans toward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants