Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 69 address bar bug #27

Closed
corysimmons opened this issue Sep 5, 2018 · 17 comments
Closed

Chrome 69 address bar bug #27

corysimmons opened this issue Sep 5, 2018 · 17 comments
Assignees
Labels

Comments

@corysimmons
Copy link

corysimmons commented Sep 5, 2018

Highlight address bar.

Alt/Option + Shift + <-- should do word selection stuff. Instead it now shifts tabs around.

Thanks for helpful extension. I use it all the time.

@mohnish
Copy link
Owner

mohnish commented Sep 5, 2018

@corysimmons I've noticed this just now. Thanks for raising this issue. It seems like something around the shortcuts changed in Chrome 69. The only thing I can currently think of is that Chrome probably has started considering the default key from the manifest.json file. That's the only place Alt+Shift+<arrow> key combination is used (for Mac). I'll try removing it and test it locally and test it. If that works, I'll ship it out as soon as I can. Once again, thanks for raising the issue and I'm glad you find the extension helpful. Cheers!

@mohnish mohnish self-assigned this Sep 5, 2018
@mohnish mohnish added the bug label Sep 5, 2018
@corysimmons
Copy link
Author

Wow, great maintainer! 🙌

This was referenced Sep 21, 2018
@dutzi
Copy link

dutzi commented Oct 3, 2018

+1
Love this extension, btw

@lucas-janon
Copy link

lucas-janon commented Oct 24, 2018

I temporarily overridden the shortcut in chrome://extensions/shortcuts
Currently using: cmd + shift + left / cmd + shift + right

@mohnish
Copy link
Owner

mohnish commented Oct 25, 2018

I've noticed something weird in Chrome 70. For those who haven't overridden the default shortcut, when you hit Shift+Alt+<arrow> from the URL bar, followed by just the Shift key or just the Alt key, the browser actually highlights the text you want to highlight in the URL bar (It still moves your tab around as a side effect). I'm still not sure what would cause this behavior.

@emiljohansson
Copy link

This is not a fix, but for some reason, changing the second dropdown from "In Chrome" to "Global" solves the address bar issue.

@mohnish
Copy link
Owner

mohnish commented Oct 25, 2018

@emiljohansson that can be programatically done. I was actually looking into that option yesterday. I’ll implement it locally and see if it works. Thanks for your input.

@mohnish
Copy link
Owner

mohnish commented Oct 25, 2018

Ok, looks like Global option is not really the right path since the shortcut triggers the extension even when Chrome is not in focus. Here's the doc https://developer.chrome.com/extensions/commands#scope

@mohnish
Copy link
Owner

mohnish commented Jan 16, 2019

I've reached out to Chrome Dev team and I haven't received any response back.

During debugging and testing, I tried switching the shortcut keys for Mac from Ctrl+Shift+Left/Right/Up/Down to Ctrl+CMD+Left/Right/Up/Down. This worked like a charm.

Pros

  • This will fix the issue and since Ctrl+CMD+Left/Right/Up/Down is not used for editing text

Cons

  • Besides the fact that this will break the extension for the existing users, the existing users will also have to get used to the new shortcuts.

So, I'm trying to decide if the change is worth it.

@corysimmons
Copy link
Author

Add those shortcuts and add a place in the extension to change the shortcut to whatever the user wants. In that area, link to this issue.

If anyone complains, carve their heart out with a spoon.

@mohnish
Copy link
Owner

mohnish commented Jan 17, 2019

Appreciate the feedback, @corysimmons!

I think I'll add a pop-up or something similar that shows up once the extension is updated. That way it'd be easier to let the existing users know of the change.

@FranklinYu
Copy link

FranklinYu commented Aug 15, 2019

I've reached out to Chrome Dev team and I haven't received any response back.

Is there any public information about this? Did you create a bug report or something?

In addition, if you decide to replace Ctrl ⌃ with Command ⌘ on macOS in the end, you can omit both windows and mac variants because the default would just work (Ctrl in default will be converted to Command ⌘ in mac).

@johangithub
Copy link

This is still happening @mohnish.

@DaveAllbirds
Copy link

Still having this issue on OSX. I love this extension but can't use it with this bug.

@mohnish
Copy link
Owner

mohnish commented Feb 2, 2022

@DaveAllbirds Hi Dave! 👋

You can always change the shortcut to CTRL+CMD+<arrow_key> to avoid this issue. Hope that helps, cheers!

@giray123
Copy link

giray123 commented Oct 6, 2022

I am also desperately waiting for a fix here. I have tried the other methods, nothing works seamlessly on Mac.

@mohnish
Copy link
Owner

mohnish commented Feb 14, 2023

Addressed in #52

@mohnish mohnish closed this as completed Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants