compute_graph_metrics - compute what we can without igraph
#1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
users without igraph will be warned, but can still get clusters/nodes metrics, and a trivial edges table
RobinL
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Is your Pull Request linked to an existing Issue or Pull Request?
With #1894 we use
igraphto computeis_bridge. Currently if this package is unavailable, you cannot compute any metrics.Give a brief description for the solution you have provided
This wraps the edge metrics method, and returns a dummy (metric-less) version of the edges table in cases where we have nothing to compute. This should be extensible to cases where we can compute some metrics without needing
igraph.This import failure is mocked for testing.
PR Checklist