Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make graph metrics public #2027

Merged
merged 8 commits into from
Mar 11, 2024
Merged

Make graph metrics public #2027

merged 8 commits into from
Mar 11, 2024

Conversation

zslade
Copy link
Contributor

@zslade zslade commented Mar 5, 2024

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

Related PRs:

Give a brief description for the solution you have provided

This PR signals the end of the first development round of the graph metrics functionality and makes it public 🙌

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Updated CHANGELOG.md (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter

@zslade zslade marked this pull request as ready for review March 5, 2024 11:11
@zslade zslade requested a review from ADBond March 5, 2024 11:38
Copy link
Contributor

@ADBond ADBond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one small change to the changelog.

Thanks for hunting down all the relevant PRs, very handy for reference!

CHANGELOG.md Outdated Show resolved Hide resolved
@RobinL
Copy link
Member

RobinL commented Mar 6, 2024

This is great! Very exciting!

@zslade zslade merged commit 81fcc58 into master Mar 11, 2024
13 checks passed
@zslade zslade deleted the metrics_method_release branch March 11, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants