Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a section on dependency management within Splink #1985

Merged
merged 12 commits into from
Mar 1, 2024

Conversation

ThomasHepworth
Copy link
Contributor

@ThomasHepworth ThomasHepworth commented Feb 20, 2024

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

Anything marked with [DEPS] and more recently:

Give a brief description for the solution you have provided

This PR aims to add documentation on:

  • Our strategy for dealing with package dependencies
  • How we deal with end-of-life python versions going forward

This summarises what we talked about previously and adds some additional guidance, where appropraite.

Please let me know if there's anything you disagree with, want added or adjusted.


NOTE: It currently points at your edge evaluation guidance because I forgot to checkout onto master and create my new branch. This shouldn't matter. I'll point it towards master once #1927 is merged.

@NickCrews
Copy link
Contributor

This looks like a great thing to think about and write down. didn't read in depth, but I did notice a type of the filename depdenency_management.md

@ThomasHepworth
Copy link
Contributor Author

This looks like a great thing to think about and write down. didn't read in depth, but I did notice a type of the filename depdenency_management.md

Hahaha, thanks Nick. I'll sort it in the morning.

Copy link
Contributor

@RossKen RossKen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together! It looks great!  🙌

Just a few minor comments

docs/dev_guides/index.md Outdated Show resolved Hide resolved
docs/dev_guides/changing_splink/dependency_management.md Outdated Show resolved Hide resolved
docs/dev_guides/changing_splink/dependency_management.md Outdated Show resolved Hide resolved
docs/dev_guides/changing_splink/dependency_management.md Outdated Show resolved Hide resolved
docs/dev_guides/changing_splink/dependency_management.md Outdated Show resolved Hide resolved
docs/dev_guides/changing_splink/dependency_management.md Outdated Show resolved Hide resolved
docs/dev_guides/changing_splink/dependency_management.md Outdated Show resolved Hide resolved
docs/img/dependency_management/python_release_cycle.png Outdated Show resolved Hide resolved
Base automatically changed from edge_evaluation_guide to master February 26, 2024 10:42
@RobinL
Copy link
Member

RobinL commented Feb 26, 2024

Just to say had a skim and this looks good to me too

Copy link
Contributor

@RossKen RossKen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! 🙌

Good to go from my end

@ThomasHepworth ThomasHepworth merged commit e746179 into master Mar 1, 2024
5 checks passed
@ThomasHepworth ThomasHepworth deleted the dependency_management_docs branch March 1, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants