-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a section on dependency management within Splink #1985
Conversation
This looks like a great thing to think about and write down. didn't read in depth, but I did notice a type of the filename |
Hahaha, thanks Nick. I'll sort it in the morning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together! It looks great! 🙌
Just a few minor comments
Just to say had a skim and this looks good to me too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! 🙌
Good to go from my end
Type of PR
Is your Pull Request linked to an existing Issue or Pull Request?
Anything marked with
[DEPS]
and more recently:sqlalchemy<2
constraint #1906Give a brief description for the solution you have provided
This PR aims to add documentation on:
This summarises what we talked about previously and adds some additional guidance, where appropraite.
Please let me know if there's anything you disagree with, want added or adjusted.
NOTE: It currently points at your edge evaluation guidance because I forgot to checkout onto master and create my new branch. This shouldn't matter. I'll point it towards master once #1927 is merged.