Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge evaluation guide #1927

Merged
merged 28 commits into from
Feb 26, 2024
Merged

Edge evaluation guide #1927

merged 28 commits into from
Feb 26, 2024

Conversation

RossKen
Copy link
Contributor

@RossKen RossKen commented Feb 5, 2024

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

Give a brief description for the solution you have provided

Basic structure and guidance on how to evaluate edges in data linkage

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Updated CHANGELOG.md (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter

@RossKen RossKen marked this pull request as ready for review February 15, 2024 17:52
ThomasHepworth
ThomasHepworth previously requested changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@ThomasHepworth ThomasHepworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comments that you are welcome to dismiss. Once you've seen them I'm happy to tick this off.

docs/topic_guides/evaluation/edge_metrics.md Show resolved Hide resolved
docs/topic_guides/evaluation/edge_metrics.md Outdated Show resolved Hide resolved
docs/topic_guides/evaluation/edge_metrics.md Outdated Show resolved Hide resolved
docs/topic_guides/evaluation/edge_metrics.md Outdated Show resolved Hide resolved
docs/topic_guides/evaluation/edge_metrics.md Outdated Show resolved Hide resolved
docs/topic_guides/evaluation/edge_metrics.md Outdated Show resolved Hide resolved
docs/topic_guides/evaluation/edge_metrics.md Outdated Show resolved Hide resolved
@RossKen @ThomasHepworth
Update docs/topic_guides/evaluation/edge_metrics.md
bdefd88 
Co-authored-by: Tom Hepworth <45356472+ThomasHepworth@users.noreply.github.com>
@ThomasHepworth
Copy link
Contributor

Ok, that should be everything checked now.

Thanks for pulling this together! As with your charts guide, this is a really valuable resources to refer back to when running through different modelling stages.

@ThomasHepworth ThomasHepworth mentioned this pull request Feb 20, 2024
Merged
4 tasks
RossKen and others added 10 commits February 22, 2024 20:44
@RossKen @samnlindsay
Update docs/topic_guides/evaluation/edge_metrics.md
7757929 
Co-authored-by: Sam Lindsay <sam.lindsay@digital.justice.gov.uk>
@RossKen @samnlindsay
Update docs/topic_guides/evaluation/edge_metrics.md
14dd934 
Co-authored-by: Sam Lindsay <sam.lindsay@digital.justice.gov.uk>
@RossKen @samnlindsay
Update docs/topic_guides/evaluation/edge_metrics.md
e32db43 
Co-authored-by: Sam Lindsay <sam.lindsay@digital.justice.gov.uk>
@RossKen @samnlindsay
Update docs/topic_guides/evaluation/edge_overview.md
2e0e819 
Co-authored-by: Sam Lindsay <sam.lindsay@digital.justice.gov.uk>
@RossKen @samnlindsay
Update docs/topic_guides/evaluation/edge_overview.md
88f5edc 
Co-authored-by: Sam Lindsay <sam.lindsay@digital.justice.gov.uk>
@RossKen @samnlindsay
Update docs/topic_guides/evaluation/edge_overview.md
23074c6 
Co-authored-by: Sam Lindsay <sam.lindsay@digital.justice.gov.uk>
@RossKen @samnlindsay
Update docs/topic_guides/evaluation/edge_overview.md
ea128bc 
Co-authored-by: Sam Lindsay <sam.lindsay@digital.justice.gov.uk>
@RossKen @samnlindsay
Update docs/topic_guides/evaluation/edge_overview.md
0a4be21 
Co-authored-by: Sam Lindsay <sam.lindsay@digital.justice.gov.uk>
@RossKen
Merge branch 'master' into edge_evaluation_guide
3e52e89
@RossKen
Merge branch 'master' into edge_evaluation_guide
909b1b5
@RossKen RossKen dismissed ThomasHepworth’s stale review February 26, 2024 10:35

Issues fixed and Tom off ill so unable to tick off

@samnlindsay samnlindsay self-requested a review February 26, 2024 10:39
@RossKen RossKen merged commit 7240302 into master Feb 26, 2024
9 checks passed
@RossKen RossKen deleted the edge_evaluation_guide branch February 26, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobinL RobinL RobinL left review comments

@samnlindsay samnlindsay samnlindsay approved these changes

@ThomasHepworth ThomasHepworth Awaiting requested review from ThomasHepworth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RossKen @ThomasHepworth @RobinL @samnlindsay