Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change file name to reflect graph naming conventions #2015

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Change file name to reflect graph naming conventions #2015

merged 3 commits into from
Mar 1, 2024

Conversation

zslade
Copy link
Contributor

@zslade zslade commented Mar 1, 2024 •
edited

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

Give a brief description for the solution you have provided

Renamed cluster_metrics.py to graph_metrics.py to align with naming conventions for graph 'entities', i.e. node-level, edge-level and cluster-level metrics all come under the umbrella 'graph metrics'.

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Updated CHANGELOG.md (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter

@zslade zslade requested a review from ADBond March 1, 2024 16:37
ADBond
ADBond approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@ADBond ADBond left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Just need to re-sort the imports to get the linter happy

@zslade zslade merged commit 8b865c3 into master Mar 1, 2024
10 checks passed
@zslade zslade deleted the script_name_change_graphs branch March 1, 2024 19:10
@zslade
Copy link
Contributor Author

zslade commented Mar 1, 2024

Cheers Andy!

@zslade zslade mentioned this pull request Mar 5, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADBond ADBond ADBond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zslade @ADBond