fix:added a check to see if simulation output exists #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: olalekan temitayo <olalekantemitayo7@gmail.com>
temitayopelumi
force-pushed
the
fix/gcbm-download-output
branch
from
3202787
to
7bc0690
Compare
YashKandalkar
approved these changes
Oct 17, 2022
HarshCasper
approved these changes
Oct 18, 2022
Freeman-kuch
pushed a commit
to Freeman-kuch/FLINT.Cloud
that referenced
this pull request
Oct 20, 2022
Signed-off-by: olalekan temitayo <olalekantemitayo7@gmail.com> Signed-off-by: olalekan temitayo <olalekantemitayo7@gmail.com> Signed-off-by: Freeman <freemanoparaocha@gmail.com>
Freeman-kuch
pushed a commit
to Freeman-kuch/FLINT.Cloud
that referenced
this pull request
Oct 20, 2022
Signed-off-by: olalekan temitayo <olalekantemitayo7@gmail.com> Signed-off-by: olalekan temitayo <olalekantemitayo7@gmail.com> Signed-off-by: Freeman <freemanoparaocha@gmail.com>
Freeman-kuch
pushed a commit
to Freeman-kuch/FLINT.Cloud
that referenced
this pull request
Oct 27, 2022
Signed-off-by: olalekan temitayo <olalekantemitayo7@gmail.com> Signed-off-by: olalekan temitayo <olalekantemitayo7@gmail.com> Signed-off-by: Freeman <freemanoparaocha@gmail.com>
Freeman-kuch
pushed a commit
to Freeman-kuch/FLINT.Cloud
that referenced
this pull request
Oct 28, 2022
Signed-off-by: olalekan temitayo <olalekantemitayo7@gmail.com> Signed-off-by: olalekan temitayo <olalekantemitayo7@gmail.com> Signed-off-by: Freeman <freemanoparaocha@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when you try to download a gcbm output, there is no check if the title exists or not. It goes ahead and shows an internal server error.
Fixes #126
Type of change
How Has This Been Tested?
If you try to download the output of the non-existed simulation, you get the response below.
Also, for simulations still in progress, or an error encountered somewhere, it refers them to check the status of the run.
...
Checklist: