refactor: test_help_all function #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shivay Lamba <shivaylamba@gmail.com>
|
@HarshCasper can you review this pull request |
HarshCasper
requested changes
Dec 23, 2022
There was a problem hiding this comment.
Hi @shivaylamba 👋
Thanks for your PR — Can you please fix the lint issue as well?
local/tests/test_rest_example.py
Outdated
| @@ -30,6 +30,8 @@ def test_help_all(self, base_endpoint): | |||
| help_all_endpoint = base_endpoint + "help/all" | |||
| help_all_response = requests.get(help_all_endpoint) | |||
| assert help_all_response.status_code == 200 | |||
|
|
|||
| def test_help_arg(self, base_endpoint): | |||
| "This test is to check the help endpoint with random i.e arg argument" | |||
There was a problem hiding this comment.
Can you please use """Doctext format""" instead of a single quote?
Signed-off-by: Shivay Lamba <shivaylamba@gmail.com>
HarshCasper
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shivay Lamba shivaylamba@gmail.com
Pull Request Template
Description
I refactored the
test_help_alltest case and added a separate test case calledtest_help_argI have also run the pytest successfully for the new test case
Fixes #212
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Pytest
Additional Context (Please include any Screenshots/gifs if relevant)
...
Checklist: