fix(#2557): error notification to payer fsp, header for source having wrong value #869
Conversation
mdebarros
commented
Nov 8, 2021
•
mdebarros
commented
- fix for In error notification to Payer FSP, header for source having wrong value project#2557
- Updated fulfil-handler logic to produce an action type "ABORT_VALIDATION" when a validation error occurs (i.e. invalid fulfilment)
- updated util/scripts/populateTestData.sh script to create a default settlement model for local dev testing
- chore: updated dependencies
- main update to central-services-shared
- added get-port to ncurc ignore list due to the breaking changes it introduces
- updated all other dependencies
- fixed audit-resolve issues
… wrong value - fix for mojaloop/project#2557 - Updated fulfil-handler logic to produce an action type "ABORT_VALIDATION" when a validation error occurs (i.e. invalid fulfilment) - updated util/scripts/populateTestData.sh script to create a default settlement model for local dev testing
- main update to central-services-shared - added get-port to ncurc ignore list due to the breaking changes it introduces - updated all other dependencies - fixed audit-resolve issues
|
the mpath vulnerability is marked as critical, so we probably shouldn't ignore it. This PR: mojaloop/object-store-lib#33 will fix it |
I have a bigger concern, I am not sure anybody is even using bulk functionality, and thus it's not being maintained. |
mdebarros
requested review from
elnyry-sam-k,
lewisdaly,
oderayi,
shashi165,
vgenev and
vijayg10
as code owners
Yeah I can cover this in an upcoming PR
Yeah that's true as well... but don't we have tests for it? |
|
Also, how did this not break any tests? |
@elnyry-sam-k please feel free to expand, or give your view on this. |
