fix(mojaloop/#3152): initial open settlementWindow is failing on clean install #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an install - updated seeds/settlementWindow2Open.js to handle an array being returned from the knex.insert operation
- fixed dependency import api changes on code-base - fixed unit tests for previous commit
mdebarros
requested review from
elnyry-sam-k,
vijayg10 and
kleyow
as code owners
elnyry-sam-k
previously approved these changes
Mar 2, 2023
mdebarros
changed the title
elnyry-sam-k
previously approved these changes
Mar 2, 2023
- Glob v9.x introducing a dependency Package "path-scurry@1.6.1" which is licensed under "BlueOak-1.0.0" which is not permitted by the Mojaloop License Policy
elnyry-sam-k
previously approved these changes
Mar 2, 2023
elnyry-sam-k
approved these changes
Mar 2, 2023
mdebarros
deleted the
feat/#3152-initial-open-settlementWindow-is-failing-on-clean-install
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(mojaloop/#3152): initial open settlementWindow is failing on clean install - mojaloop/project#3152
This issue was introduced in Knex v2.4.0 with the following change:
chore: updated dependencies and fixed unit tests
fixed api changes on Glob dependency(reverted due to a license issue with v9.x)