Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Logger level configuration available for Winston #8

Closed
mdebarros opened this issue Mar 13, 2018 · 2 comments
Closed

No Logger level configuration available for Winston #8

mdebarros opened this issue Mar 13, 2018 · 2 comments

Comments

@mdebarros
Copy link
Member

Log level configuration should be added to https://github.com/mojaloop/central-services-shared/blob/master/src/logger.js

Needs to provide a function to be able to set the method, or include it as a param for function Logger()

@igncp
Copy link

igncp commented Aug 24, 2019

Hi, I was wondering if this issue is still valid. I can see that the level can be set via environment variable. Additionally, Winston allows setting the logger level after creation:

logger.transports.console.level = 'debug';
logger.setLevels('debug'); // for the instance

I could reference this link in the repo README file, or maybe I misunderstood the issue. Thanks.

@lewisdaly
Copy link
Contributor

Closing as outdated

mdebarros pushed a commit that referenced this issue Feb 7, 2022
…#96)

* PositionHandler::positions::commit
* Avoid knex version warning: http://knexjs.org/#Schema-timestamps
* Fixing minor bugs
* .then to await
* Fulfil reject scenario
* Move projection to facade transaction
* Unit tests batch 1
* Transfer facade unit test coverage 100 percent
* Position facade unit test coverage 100 percent
* Inserting placeholders for integration tests
* refactored the integration tests for testPI2/integration/domain/participant/index.test.js (#7)
* Integration test handlers reworked
* Updated registerHandler functions for positions and prepare to allow for specific registration of FSPs (#8)
* Updated registerHandler functions for positions and prepare to allow for specific registration of FSPs
* Removed comment and fixed jsdoc param name
* handlers integration test additions
* integration tests additions
* Finilizing integration tests work
* added unit tests (#9)
* seeds and domain/participant 100
* Adding more unit tests to improve coverage
* Reduce wait time during unit testing for time.js
* Enable sidecar and auth keychain
* Disable dev seed
* Changes as per request by rmothilal
mdebarros pushed a commit that referenced this issue Feb 7, 2022
* Temp sidecar and token fix

* Delete deprecated and update first 3 scripts

* Migration scripts 9-11

* Migration scripts 12-14

* Migration scripts 15-16

* Migration scripts 22-24

* Migration scripts 17-21

* Migration scripts 17-21

* Migration scripts 17-21

* Migration scripts 25-27

* Migration scripts 34 and review fixes to ilpPacket

* Migration scripts 29

* fixed ilpCondition spelling error

* Migration scripts 31

* Migration scripts 28, 30

* Migration scripts 32-33

* Corrections and cleanup

* npm run migrate FIXES

* Fix /participant; Remove /charge, /party, /role, /fee

* Refactor: Move from domain to model & camelCase

* domain/transfer/models to models/transfer, seeds

* Changed transfer facade getById

* Transfer Prepare

* Transfer Commit

* Pre- tests clean

* Test files maintenance

* Additional clean up

* added unit test cases

* fixed dependancies into few tests

* Adding placeholder unit test files

* Fixed admin/index.js unit test

* Added tests for transferFulfilment and transferParticipant

* Tests for transferFulfilment

* Sinon.createSandbox

* Unit testing for transferExtension

* added test cases

* Unit tests for ilpPacket

* Unit tests for transfer/facade init - WIP

* fixes for tests and tweaks

* added test cases

* fixes for tests and tweaks (#1)

* removed unused test and fixed position test

* some fixes but still broken tests

* merged projections

* merged projections second attempt

* Feature/db model changes georgi (#2)

* fixes for tests and tweaks

* removed unused test and fixed position test

* some fixes but still broken tests

* Standard fixes

* fixes for producer and consumer. need to test properly

* add producer to list
made some addons

* Disable failing test scripts

* projection fixed

* deleted transform.test.js

* updated dependencies

* unit/models/transfer/facade.test.js

* fixed testPI2/unit/domain/participant/index.test.js

* testPI2/unit/handlers/transfers/handler.test.js

* unit/handlers/transfers/handler.test.js

* Feature/db model changes georgi (#3)

* fixes for tests and tweaks

* removed unused test and fixed position test

* some fixes but still broken tests

* fixes for producer and consumer

* add producer to list

* updated dependencies

* positions model layer

* Integration tests fix Part 1

* Fix & merge rmothilal

* Disable broken integration tests

* updating migration scripts to new knex standards for table creation

* Feature/db model changes georgi (#5)

* fixes for tests and tweaks

* removed unused test and fixed position test

* some fixes but still broken tests

* fixes for producer and consumer. need to test properly

* add producer to list
made some addons

* updated dependencies

* Feature/db model changes georgi (#3)

* fixes for tests and tweaks

* removed unused test and fixed position test

* some fixes but still broken tests

* fixes for producer and consumer

* add producer to list

* updated dependencies

* positions model layer

* updating migration scripts to new knex standards for table creation

* disconnect topicName

* Feature/#355integrations

@vgenev integration tests fixes

* Cleaning up code and renaming integration test file names

* Changes according to rmothilal PR review

* WIP

* premerge with Rajiv db changes

* WIP

* WIP

* WIP

* PositionHandler::positions::commit

* Avoid knex version warning: http://knexjs.org/#Schema-timestamps

* Fixing minor bugs

* fixes for prepare position still needs rework

* .then to await

* fixes. now writes to database and updates accordingly. minor defects to fix

* fixes to allow flow to continue to transfer handler

* removal of space

* Fulfil reject scenario

* Move projection to facade transaction

* Unit tests batch 1

* Transfer facade unit test coverage 100 percent

* temporary fix for sorting transfer state change Id

* Position facade unit test coverage 100 percent

* Inserting placeholders for integration tests

* refactoring the position/facade

* moar refactoring

* fixed array.from map callback

* refactored the integration tests for testPI2/integration/domain/participant/index.test.js (#7)

* position facade refactored and debuged. changed the test prepare route to return different transfers

* small issue on the handler fixed

* fixed some string to numbers parsing issues

* moar refactoring. a small one

* Integration test handlers reworked

* Updated registerHandler functions for positions and prepare to allow for specific registration of FSPs (#8)

* Updated registerHandler functions for positions and prepare to allow for specific registration of FSPs

* Removed comment and fixed jsdoc param name

* merging

* merged and commented out few tests

* handlers integration test additions

* integration tests additions

* Finilizing integration tests work

* added unit tests (#9)

* seeds and domain/participant 100

* Adding more unit tests to improve coverage

* Reduce wait time during unit testing for time.js

* Enable sidecar and auth keychain

* Disable dev seed

* adjusted the position calculations according the latest review

* adjusted positions calculations according the latest review take2

* merged with #308

* fixed handlers tests

* unit tests running ok now

* fixed 573 tests

* integration test fix

* fixes for tests as well as making save transfer prepare a transaction

* update node package.json for cache refresh on circleci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants