feat(thirdparty): auth svc charts #452
Conversation
lewisdaly
requested review from
elnyry-sam-k,
mdebarros and
vijayg10
as code owners
lewisdaly
changed the title
There was a problem hiding this comment.
Hey @lewisdaly,
Made some minor change suggestions.
Let me know what you think.
Otherwise looks good.
| template: | ||
| metadata: | ||
| labels: | ||
| {{- include "auth-svc.selectorLabels" . | nindent 8 }} |
There was a problem hiding this comment.
This should be labels not selectorLabels, btw this is also something that needs to be fixed in the ml-operator chart.
selectorLabels should only be used for selectors ;D
| configMap: | ||
| name: auth-svc-config | ||
| items: | ||
| {{- range $k, $v := index .Values.config }} |
There was a problem hiding this comment.
Any reason that this generally loads all config files, but the above volumeMounts a specific file production.json?
If you are not planning to do something like that, I would just define the config files you need.
There was a problem hiding this comment.
Sure, I can do that.
I thought this approach would be more generic, in case we wanted to specify more than one file and be able to switch between them easily. That is similar to the approach we use when switching development environments with convict - see https://github.com/mojaloop/auth-service/tree/master/config for example
There was a problem hiding this comment.
I am not a fan of that approach, i.e. uploading multiple configurations and selecting the desired one based on the target environment.
I would prefer to be explicit, i.e. if it's the dev environment, then only configure the dev environment configs, etc.
|
@mdebarros ready to go again. |
The thirdparty charts have 3 separate services, so I'm going to add them all one at a time to make it easier to review and debug.
This PR adds support for the auth-svc, which stores and validates consents, and checks transactions for valid signatures before approving them.
It has 2 prerequisites (mysql, redis), which aren't installed in the chart, but I did include an example of how an end user might install them on their own.
Part of mojaloop/project#2450