feat(thirdparty): add thirdparty support to mojaloop-simulator chart #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewisdaly
requested review from
elnyry-sam-k,
mdebarros and
vijayg10
as code owners
lewisdaly
commented
Oct 21, 2021
|
|
||
| # Path to JWS signing key (private key of THIS DFSP) | ||
| JWS_SIGNING_KEY_PATH: "/jwsSigningKey/private.key" # do not change this unless you know what you are doing - this will break the chart | ||
| JWS_SIGNING_KEY_PATH: "/jwsSigningKey.key" # do not configure- will break the chart |
There was a problem hiding this comment.
TODO: Open a ticket for this - it's masking an insecure secret
There was a problem hiding this comment.
Link to issue: mojaloop/project#2558
Thanks @lewisdaly
mdebarros
approved these changes
Oct 22, 2021
|
Thanks @mdebarros will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes mojaloop/project#2532
Instead of defining a new chart, I decided to add an optional deployment of the
thirdparty-sdkcomponent to the existing mojaloop-simulator chart to keep the maintenance burden as low as possible.The thirdparty-sdk is disabled by default, but you can turn it on when specifying a participant in the mojaloop-simulator values.yaml file like so: