Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(mojaloop/#3459): nodejs upgrade #181

Merged
merged 11 commits into from
Jan 4, 2024
Merged

chore(mojaloop/#3459): nodejs upgrade #181

merged 11 commits into from
Jan 4, 2024

Conversation

kleyow
Copy link
Contributor

@kleyow kleyow commented Jan 3, 2024 •
edited

chore(mojaloop/#3459): NodeJS version upgrade - mojaloop/project#3459

  • Upgraded nodejs from v16 to v18 LTS
  • Applied CI changes as previously implemented in sdk-scheme-adapter
  • Updated NPM dependencies
  • Resolved all audit issues
  • Migrated master branch to main branch
  • Pegged json-schema-faker in shared lib that is causing url rending issues. Poor documentation and huge commit diff between versions.
  • Override carot dependency in react scripts that breaks licensing check

Original PR: #178

@kleyow kleyow closed this Jan 4, 2024
@kleyow kleyow reopened this Jan 4, 2024
@kleyow
Copy link
Contributor Author

kleyow commented Jan 4, 2024

mojaloop/project#3459 (comment)
mojaloop/project#3459 (comment)

@elnyry-sam-k elnyry-sam-k merged commit 6870bbd into main Jan 4, 2024
7 checks passed
@elnyry-sam-k
Copy link
Member

Thanks Kevin

@kleyow kleyow deleted the chore/#3459-nodejs-upgrade branch January 8, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijayg10 vijayg10 vijayg10 approved these changes

@mdebarros mdebarros Awaiting requested review from mdebarros mdebarros is a code owner

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k elnyry-sam-k is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kleyow @elnyry-sam-k @vijayg10 @oderayi