ALS is sending out multiple requests to participants for both Oracle records that match non-subId and subId result set

[mdebarros]

Summary:

ALS is sending out multiple requests to participants for both Oracle records that match non-subId and subId result set with incorrect API operation GET /parties/{partyType}/{partyId} (i.e. no SubId in URI).

ALS incorrectly sends a GET /parties/{partyType}/{partyId} for each result with no SubId and with the SubId to the destination Participant

Severity:
Low

Priority:
Low

Expected Behavior

ALS will sends a GET /parties/{partyType}/{partyId} for each result with no SubId to the destination Participant

Steps to Reproduce

1. Register a Party on the Mojaloop-Simulator Oracle with no SubId and a SubId

Example:

$ curl http://localhost:8080/oracle/participants/MSISDN/27713803912
{"partyList":[{"fspId":"payeefsp","currency":"USD"},{"fspId":"payeefsp","currency":"USD","partySubIdOrType":"30"}]}

2. Send a GET /parties/MSISDN/27713803912

3. Only a single GET /parties/MSISDN/27713803912 request should be forwarded to the payeefsp.

Specifications

• Component (if known): Account-Lookup-Service
• Version: v11.7.0
• Platform: moja1
• Subsystem: n/a
• Type of testing: Manual
• Bug found/raised by: @vijayg10

Notes:

• Severity when opened: Low
• Priority when opened: Low

[mdebarros]

PR open mojaloop/account-lookup-service#424

[mdebarros]

PR open mojaloop/account-lookup-service#424

PR for Helm v13.0.2.

Test Suite:GP Tests
Environment:moja2.test.mojaloop.live
┌───────────────────────────────────────────────────┐
│                      SUMMARY                      │
├───────────────────┬───────────────────────────────┤
│ Total assertions  │ 2064                          │
├───────────────────┼───────────────────────────────┤
│ Passed assertions │ 2064                          │
├───────────────────┼───────────────────────────────┤
│ Failed assertions │ 0                             │
├───────────────────┼───────────────────────────────┤
│ Total requests    │ 446                           │
├───────────────────┼───────────────────────────────┤
│ Total test cases  │ 99                            │
├───────────────────┼───────────────────────────────┤
│ Passed percentage │ 100.00%                       │
├───────────────────┼───────────────────────────────┤
│ Started time      │ Tue, 17 Aug 2021 08:46:09 GMT │
├───────────────────┼───────────────────────────────┤
│ Completed time    │ Tue, 17 Aug 2021 08:48:32 GMT │
├───────────────────┼───────────────────────────────┤
│ Runtime duration  │ 142526 ms                     │
└───────────────────┴───────────────────────────────┘

View Report