Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transfers are not being assigned to a settlementWindow on transfers+json;version=1.1 #2525

Closed
mdebarros opened this issue Oct 1, 2021 · 1 comment
Assignees
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it
Milestone

Comments

@mdebarros
Copy link
Member

mdebarros commented Oct 1, 2021

Summary:
transfers are not being assigned to a settlementWindow when receiving a PUT /transfer/{transferId} callback when using transfers+json;version=1.1 (i.e. transverState=RESERVED).

Severity:
High

Priority:
Critical

Expected Behavior
transfers should be assigned to the current open settlementWidow when receiving a PUT /transfer/{transferId} callback when using transfers+json;version=1.1 (i.e. transverState=RESERVED).

Steps to Reproduce

  1. Send a POST /transfer using API transfers+json;version=1.1
  2. Send an appropriate PUT /transfer/{transferId} with transferState=RESERVED
  3. Run the following query on the DB
SELECT * 
FROM transfer AS t
   INNER JOIN
   transferStateChange AS tsc
   ON t.transferId = tsc.transferId
   INNER JOIN
   transferParticipant AS tsp
   ON t.transferId = tsp.transferId
   INNER JOIN
   transferFulfilment AS tsf
   ON t.transferId = tsf.transferId
   INNER JOIN
   participantCurrency AS pc
   ON tsp.participantCurrencyId = pc.participantCurrencyId
   WHERE t.transferId = '{transferId}' AND transferStateId = "COMMITTED"  AND tsp.ledgerEntryTypeId=1;
   

Check the settlementWindowId column, it should be null.

Specifications

  • Component (if known): Central-ledger
  • Version: 13.14.2
  • Platform: n/a
  • Subsystem: n/a
  • Type of testing: n/a
  • Bug found/raised by: @mdebarros

Notes:

  • Severity when opened:
  • Priority when opened:
@mdebarros mdebarros added bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it labels Oct 1, 2021
@mdebarros mdebarros self-assigned this Oct 1, 2021
mdebarros added a commit to mdebarros/central-ledger that referenced this issue Oct 1, 2021
…indow on transfers version=1.1

- Fix for [transfers are not being assigned to a settlementWindow on transfers+json;version=1.1 #2525](mojaloop/project#2525)
- Added devspace patterns to gitignore
@mdebarros
Copy link
Member Author

@elnyry-sam-k elnyry-sam-k added this to the Sprint 15.5 milestone Oct 1, 2021
mdebarros added a commit to mojaloop/central-ledger that referenced this issue Oct 1, 2021
…indow on transfers version=1.1 (#866)

- Fix for [transfers are not being assigned to a settlementWindow on transfers+json;version=1.1 #2525](mojaloop/project#2525)
- Added devspace patterns to gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it
Projects
None yet
Development

No branches or pull requests

2 participants