Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transfers PUT callback on version=1.1 is not assigning destination headers correctly #2527

Closed
mdebarros opened this issue Oct 1, 2021 · 0 comments
Closed

transfers PUT callback on version=1.1 is not assigning destination headers correctly #2527

mdebarros opened this issue Oct 1, 2021 · 0 comments
Assignees
@mdebarros
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it
Milestone
Sprint 15.5

Comments

@mdebarros
Copy link
Member

mdebarros commented Oct 1, 2021 •
edited by elnyry-sam-k
Loading

Summary:
transfers PUT callback on version=1.1 is not assigning destination headers correctly

Severity:
High

Priority:
Critical

Expected Behavior

  1. Destination header should have the value of "switch" when forwarding a PUT /transfers/{transferId} callback with transferState=RESERVED
  2. Signature header should be removed and regenerated (if and only if keys have been configured).

Steps to Reproduce

  1. Send a POST /transfer using API transfers+json;version=1.1
  2. Send an appropriate PUT /transfer/{transferId} with transferState=RESERVED

Specifications

  • Component (if known): ml-api-adapter
  • Version: 11.1.6
  • Platform: n/a
  • Subsystem: n/a
  • Type of testing: n/a
  • Bug found/raised by: @mdebarros

Notes:

  • Severity when opened: High
  • Priority when opened: Critical
@mdebarros mdebarros added bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it labels Oct 1, 2021
@elnyry-sam-k elnyry-sam-k added this to the Sprint 15.5 milestone Oct 1, 2021
mdebarros added a commit to mdebarros/ml-api-adapter that referenced this issue Oct 1, 2021
@mdebarros
fix(mojaloop/#2527):transfers PUT callback on v1.1 is not assigning d…
225964a 
…estination headers correctly

- fix for [transfers PUT callback on version=1.1 is not assigning destination headers correctly #2527](mojaloop/project#2527)
- added/updated unit tests to acomodate the above change
- updated dependencies
- fixed audit-resolve issues
@mdebarros mdebarros mentioned this issue Oct 1, 2021
Merged
mdebarros added a commit to mojaloop/ml-api-adapter that referenced this issue Oct 1, 2021
@mdebarros
fix(mojaloop/#2527): transfers put callback on v1.1 is not assigning …
1d1212e 
…destination headers correctly (#486)

- fix for [transfers PUT callback on version=1.1 is not assigning destination headers correctly #2527](mojaloop/project#2527)
- added/updated unit tests to accommodate the above change
- updated dependencies
- fixed audit-resolve issues
- updated gitignore to include devspace patterns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdebarros mdebarros

Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it
Projects
None yet
Milestone
Sprint 15.5
Development

No branches or pull requests
2 participants
@elnyry-sam-k @mdebarros