Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bulk-api-adapter fails when extensionLists are not send in the POST /bulkTransfer requests #2585

Closed
mdebarros opened this issue Nov 19, 2021 · 0 comments
Closed

bulk-api-adapter fails when extensionLists are not send in the POST /bulkTransfer requests #2585

mdebarros opened this issue Nov 19, 2021 · 0 comments
Assignees
@mdebarros
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it

Comments

@mdebarros
Copy link
Member

mdebarros commented Nov 19, 2021 •
edited
Loading

Summary:

bulk-api-adapter fails when extensionLists are not send in the POST /bulkTransfer requests.

Severity:
High

Priority:
Critical

Expected Behavior

Post /bulkTransfer requests should be processed by the bulk-api-adapter with a valid HTTP accept code.

Steps to Reproduce

  1. Install Mojaloop v13.1.0 Candidate Release
  2. Run the v13.1.0 Provisioning Collection
  3. Run the v13.1.0 Bulk Transfer Test Collection - remove the extensionList fields from the request

Specifications

  • Component (if known): bulk-api-adapter
  • Version: v1.x - v12.0.1
  • Platform: n/a
  • Subsystem: n/a
  • Type of testing: Testing-Toolkit
  • Bug found/raised by: @mdebarros

Notes:

  • Severity when opened: High
  • Priority when opened: Critical
@mdebarros mdebarros added oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it bug Something isn't working or it has wrong behavior on a Mojaloop Core service epic labels Nov 19, 2021
@elnyry-sam-k elnyry-sam-k removed the epic label Nov 19, 2021
mdebarros added a commit to mdebarros/central-object-store that referenced this issue Nov 19, 2021
@mdebarros
fix(mojaloop/#2585): bulk-api-adapter fails when extensionLists are n…
cfeb6be 
…ot send in the POST /bulkTransfer requests

fix for mojaloop/project#2585:
- added some safety checks on chained object "dot" notation references
@mdebarros mdebarros mentioned this issue Nov 19, 2021
Merged
mdebarros added a commit to mojaloop/object-store-lib that referenced this issue Nov 19, 2021
@mdebarros
fix(mojaloop/#2585): bulk-api-adapter fails when extensionLists are n…
cd3b7bc 
…ot send in post /bulktransfer (#35)

fix for mojaloop/project#2585:
- added some safety checks on chained object "dot" notation references
- aligned .nvmrc to ci-cd builds (i.e. Node v12.16.1)
mdebarros added a commit to mdebarros/bulk-api-adapter that referenced this issue Nov 19, 2021
@mdebarros
fix(mojaloop/#2585): bulk-api-adapter fails when extensionLists are n…
abadbf3 
…ot send in the POST /bulkTransfer requests

fix for mojaloop/project#2585:
- updated object-store-lib depenendency

chore: updated gitignore to include devspace files
@mdebarros mdebarros mentioned this issue Nov 19, 2021
Merged
@mdebarros mdebarros self-assigned this Nov 19, 2021
mdebarros added a commit to mojaloop/bulk-api-adapter that referenced this issue Nov 22, 2021
@mdebarros
fix: release v13.1.0 (#69)
5464a62 
fix(mojaloop/#2584): bulk-api-adapter is unable to process requests with individualTransfers[].extensionLists
- fix for mojaloop/project#2584:
    - removed linked references in api swagger definition as a temporary work-around due to the internal issue between hapi-swagger and joi dependencies -> this will be addressed in future once it is replaced with openapi-backend plugin

fix(mojaloop/#2585): bulk-api-adapter fails when extensionLists are not send in the POST /bulkTransfer requests
- fix for mojaloop/project#2585:
    - updated object-store-lib depenendency

chore: updated gitignore to include devspace files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdebarros mdebarros

Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elnyry-sam-k @mdebarros