Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run 3PPI TTK tests with 3PPI services enabled #2650

Closed
9 of 10 tasks
elnyry-sam-k opened this issue Jan 20, 2022 · 7 comments
Closed
9 of 10 tasks

Run 3PPI TTK tests with 3PPI services enabled #2650

elnyry-sam-k opened this issue Jan 20, 2022 · 7 comments
Assignees
@kleyow @mdebarros
Labels
oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it oss-pisp OSS PISP team's items - stories, bugs, epics story
Milestone
Sprint 17.3

Comments

@elnyry-sam-k
Copy link
Member

elnyry-sam-k commented Jan 20, 2022 •
edited
Loading

Goal:

As an adopter of Mojaloop (and 3PPI services)

I want to be able to take the 3PPI TTK end-to-end tests available and run them successfully

so that I can be assured of the quality of the releases (and that the tests pass with expected results)

Note: This is a follow-up to the Epic: #2385

Acceptance Criteria:

  • On a standard (using a Mojaloop helm release) Mojaloop deployment, setup for 3PPI services is done
  • The 3PPI TTK end-to-end tests are run
  • Bugs are logged for any failures, if the pass-rate is not 100%
  • Update documentation as relevant

Complexity: Medium

Uncertainty: Low

Tasks:

  • Get a Mojaloop deployment (using a helm release) with 3PPI services enabled
  • Get 3PPI TTK end-to-end test suites running
  • If the pass rate is not 100%, log bugs for failures

Done

  • Acceptance Criteria pass
  • Bugs are logged for failures with priority, severity assigned

Pull Requests:

  • TBD

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@elnyry-sam-k elnyry-sam-k added story oss-pisp OSS PISP team's items - stories, bugs, epics labels Jan 20, 2022
@elnyry-sam-k elnyry-sam-k changed the title Run 3PPI TTK end-to-end test suites on a Mojaloop deployment with 3PPI services enabled Run 3PPI TTK test suites on a Mojaloop deployment with 3PPI services enabled Jan 20, 2022
@elnyry-sam-k elnyry-sam-k changed the title Run 3PPI TTK test suites on a Mojaloop deployment with 3PPI services enabled Run 3PPI TTK tests with 3PPI services enabled Jan 20, 2022
@elnyry-sam-k elnyry-sam-k added this to the Sprint 17.1 milestone Feb 3, 2022
@elnyry-sam-k elnyry-sam-k added the oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it label Feb 3, 2022
@elnyry-sam-k elnyry-sam-k mentioned this issue Feb 11, 2022
Closed
@lewisdaly
Copy link
Contributor

@mdebarros added the thirdparty-sdk for the simulators in helm/mojaloop-simulator

https://github.com/mojaloop/helm/blob/master/mojaloop-simulator/values.yaml#L29-L38

So to turn 'on' the 3p api features in our simulated DFSPS, you just need to change that field in the values.yaml

@mdebarros
Copy link
Member

https://github.com/mojaloop/helm/blob/master/mojaloop-simulator/values.yaml#L29-L38

Thanks @lewisdaly, does that mean we need to have new simulators configured for testing 3P API Features? Or can we just bolt it on one of our existing simulators?

@mdebarros
Copy link
Member

mdebarros commented Mar 7, 2022 •
edited
Loading

Snag List

1. The following env variables from the Onboarding collection need to be defined:

HOST_ORACLE_CONSENT

DFSPA_NAME
DFSPA_CB_FSPIOP <-- Is this for the SDK Scheme Adapter?
DFSPA_CB_THIRDPARTY <-- I assume this is for the ThirdParty Scheme Adapter?

DFSPB_NAME
DFSPB_CB_FSPIOP
DFSPB_CB_THIRDPARTY? <-- this does not seem to be used, I have added it here because I assume it should be

PISP_NAME
PISP_CB_FSPIOP
PISP_CB_THIRDPARTY

CENTRALAUTH_NAME <-- Not sure what goes here?
CENTRALAUTH_CB_FSPIOP <-- Is this just the Auth Svc?

2. The following env variables from the Thirdparty collection need to be defined:

PISP_THIRDPARTY_SDK_OUTBOUND_URL= http://{{helm-install-name}}-sim-pisp-thirdparty-sdk:4006

3. Thirdparty collection is not parameterized (even though the Onboarding collection is?)

a. dfsp names
b. dfsp users
c. transaction UUIDs are not generated but hardcoded

@elnyry-sam-k elnyry-sam-k modified the milestones: Sprint 17.1, Sprint 17.3 Mar 7, 2022
@mdebarros mdebarros mentioned this issue Mar 10, 2022
Merged
@mdebarros
Copy link
Member

Thirdparty helm test setup collection: ml-ttk-test-setup-tp

--------------------FINAL REPORT--------------------
Test Suite:Thirdparty Provisioning Collection
Environment:Development
┌───────────────────────────────────────────────────┐
│                      SUMMARY                      │
├───────────────────┬───────────────────────────────┤
│ Total assertions  │ 137                           │
├───────────────────┼───────────────────────────────┤
│ Passed assertions │ 137                           │
├───────────────────┼───────────────────────────────┤
│ Failed assertions │ 0                             │
├───────────────────┼───────────────────────────────┤
│ Total requests    │ 135                           │
├───────────────────┼───────────────────────────────┤
│ Total test cases  │ 15                            │
├───────────────────┼───────────────────────────────┤
│ Passed percentage │ 100.00%                       │
├───────────────────┼───────────────────────────────┤
│ Started time      │ Thu, 10 Mar 2022 15:53:10 GMT │
├───────────────────┼───────────────────────────────┤
│ Completed time    │ Thu, 10 Mar 2022 15:53:25 GMT │
├───────────────────┼───────────────────────────────┤
│ Runtime duration  │ 15710 ms                      │
└───────────────────┴───────────────────────────────┘

Thirdparty verification tests: ml-ttk-test-val-tp

--------------------FINAL REPORT--------------------
Test Suite:Thirdparty Tests
Environment:Development
┌───────────────────────────────────────────────────┐
│                      SUMMARY                      │
├───────────────────┬───────────────────────────────┤
│ Total assertions  │ 21                            │
├───────────────────┼───────────────────────────────┤
│ Passed assertions │ 21                            │
├───────────────────┼───────────────────────────────┤
│ Failed assertions │ 0                             │
├───────────────────┼───────────────────────────────┤
│ Total requests    │ 20                            │
├───────────────────┼───────────────────────────────┤
│ Total test cases  │ 8                             │
├───────────────────┼───────────────────────────────┤
│ Passed percentage │ 100.00%                       │
├───────────────────┼───────────────────────────────┤
│ Started time      │ Thu, 10 Mar 2022 15:53:31 GMT │
├───────────────────┼───────────────────────────────┤
│ Completed time    │ Thu, 10 Mar 2022 15:53:35 GMT │
├───────────────────┼───────────────────────────────┤
│ Runtime duration  │ 4375 ms                       │
└───────────────────┴───────────────────────────────┘
TTK-Assertion-Report-multi-2022-03-10T15:53:35.561Z.html was generated
Terminate with exit code 0
Done

@mdebarros mdebarros mentioned this issue Mar 10, 2022
Merged
mdebarros added a commit to mojaloop/helm that referenced this issue Mar 10, 2022
@mdebarros
chore: run 3ppi ttk tests with 3ppi services enabled
651c2db 
chore: run 3ppi ttk tests with 3ppi services enabled - mojaloop/project#2650
- fixed thirdparty helm chart deployment issues
- fixed thirdparty helm chart configuration issue to successfully run the Thirdparty TTK tests
- added Thirdparty Provisioning and Verification Collections as optional Helm Tests
- added Mojaloop-Simulators as a dependency to the Thirdparty wrapper chart
   - configured Simulators for DFSPA, DFSPB and PISP to support the Thirdparty Verification tests
- added thirdparty charts to update-charts-dep.sh
- upgraded thirdparty auth-svc docker image from v11.10.1 to v11.11.1
- added init-containers to thirdparty helm charts (auth-svc & consent-svc) to run database migration/seed scripts
- updated README documentation to clarify instructions on how to enable/test Thirdparty features
- updated release notes
mdebarros added a commit to mojaloop/testing-toolkit-test-cases that referenced this issue Mar 10, 2022
@mdebarros
chore(mojaloop/#2650): run 3ppi ttk tests with 3ppi services enabled (#…
8fa7cca 
…67)

chore(mojaloop/#2650): Run 3PPI TTK tests with 3PPI services enabled - mojaloop/project#2650
- added provisioning_thirdparty/dfspb_parties.json to load party information into DFSPB's backend simulator
- updated minor test asserts
@elnyry-sam-k
Copy link
Member Author

elnyry-sam-k commented Mar 10, 2022 •
edited
Loading

This is awesome! Great work @mdebarros , @kleyow and thanks for the support @lewisdaly

@lewisdaly
Copy link
Contributor

That's awesome @mdebarros @kleyow !

mdebarros added a commit to mojaloop/helm that referenced this issue Mar 11, 2022
@mdebarros
chore(mojaloop/#2650): run 3ppi ttk tests with 3ppi services enabled (#…
a29be6f 
…467)

chore: run 3ppi ttk tests with 3ppi services enabled - mojaloop/project#2650
- fixed thirdparty helm chart deployment issues
- fixed thirdparty helm chart configuration issue to successfully run the Thirdparty TTK tests
- added Thirdparty Provisioning and Verification Collections as optional Helm Tests
- added Mojaloop-Simulators as a dependency to the Thirdparty wrapper chart
   - configured Simulators for DFSPA, DFSPB and PISP to support the Thirdparty Verification tests
- added thirdparty charts to update-charts-dep.sh
- upgraded thirdparty auth-svc docker image from v11.10.1 to v11.11.1
- added init-containers to thirdparty helm charts (auth-svc & consent-svc) to run database migration/seed scripts
- updated README documentation to clarify instructions on how to enable/test Thirdparty features
- updated release notes
- fixes and minor optimization to CI-CD config - merged `build` job into `test` job as it's required for `helm lint` command to run
@mdebarros
Copy link
Member

Issue tested with v13.1.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kleyow kleyow

@mdebarros mdebarros

Labels
oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it oss-pisp OSS PISP team's items - stories, bugs, epics story
Projects
None yet
Milestone
Sprint 17.3
Development

No branches or pull requests
5 participants
@lewisdaly @kleyow @elnyry-sam-k @mdebarros @georgi-logodazhki