Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mojaloop GP - pre cleanup and post clean up scripts failing when tested on mojaloop helm v15 release #3165

Closed
7 tasks done
sri-miriyala opened this issue Mar 15, 2023 · 3 comments
Closed
7 tasks done

Mojaloop GP - pre cleanup and post clean up scripts failing when tested on mojaloop helm v15 release #3165

sri-miriyala opened this issue Mar 15, 2023 · 3 comments
Assignees
@mdebarros @sri-miriyala
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service core-dev-squad oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it

Comments

@sri-miriyala
Copy link

sri-miriyala commented Mar 15, 2023 •
edited by elnyry-sam-k
Loading

Summary:
Some of the settlement related tests in pre GP cleanup and post GP cleanup, especially around "create settlement" are failing when tested against mojaloop helm v15 release in moja2 env.

Severity:
(Low, Medium, High)

Priority:
(Critical, Medium, Low)

Expected Behavior

Pre and post cleanup scripts to be successful without failures on mojaloop helm release v15.0.0

Steps to Reproduce

  1. On a deployment with v15.0.0 RC / dev release, run tests from here: https://github.com/mojaloop/testing-toolkit-test-cases/tree/v14.1.0
  2. Failures on pre GP cleanup and post GP cleanup can be seen.

Tasks:

  • Create separate collections for pre/post clean-up so that it these collections can be used selectively as needed
  • Validate the fix by running multiple times
  • Remove the FundsIn collection from GP
  • Validate settlements position changes before GP, after GP, and after cleanup
  • Validate the interchange fee positions
  • Add steps to run clean up collections to documentation in testing-toolkit-test-cases and Helm release notes (testing notes section)
  • Add cleanup collection to the helm tests [@mdebarros]

Specifications

  • Component (if known):
  • Version: helm v15.0.0 RC (or dev release)
  • Platform: Mojaloop
  • Subsystem:
  • Type of testing: functional
  • Bug found/raised by: @mdebarros

Notes:

  • Severity when opened:
  • Priority when opened:

Tasks\Solution
@sri-miriyala sri-miriyala added the bug Something isn't working or it has wrong behavior on a Mojaloop Core service label Mar 15, 2023
@mdebarros mdebarros mentioned this issue Mar 15, 2023
Merged
mdebarros added a commit to mojaloop/testing-toolkit-test-cases that referenced this issue Mar 15, 2023
@mdebarros
feat(mojaloop/#3122): mojaloop helm release v15.0.0 (#116)
142add7 
feat(mojaloop/#3122): mojaloop helm release v15.0.0 #3122  - mojaloop/project#3122
- Temporary removed Pre-Post Cleanup scripts until they can be fixed for stability and consistency. This will be addresed with mojaloop/project#3165.
@sri-miriyala sri-miriyala changed the title Mojaloop GP - pre cleanup and post clean up scripts failing when tested on v15 release Mojaloop GP - pre cleanup and post clean up scripts failing when tested on mojaloop helm v15 release Mar 15, 2023
@sri-miriyala sri-miriyala self-assigned this Mar 15, 2023
@chris-me-law chris-me-law added the to-be-refined This story is ready to be groomed label Mar 16, 2023
@elnyry-sam-k elnyry-sam-k added the oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it label Mar 16, 2023
@elnyry-sam-k
Copy link
Member

Hey team! Please add your planning poker estimate with Zenhub @sri-miriyala @mdebarros

@elnyry-sam-k elnyry-sam-k removed the to-be-refined This story is ready to be groomed label Mar 16, 2023
@sri-miriyala
Copy link
Author

sri-miriyala commented Mar 21, 2023 •
edited
Loading

Story3165

The above scree shot is showing the position values of test FSPs in different stages.
Those stages are

  1. Before running GoldenPath collection
  2. After Running GP
  3. After running cleanup collection
    The red arrows showing the position values in these 3 different stages. The goal is to reset positions through the clean up collection, so that we will not have issues of failing tests due to insufficient funds on the payer fsp when transfers run during tests. The above screenshot is showing the position values are reset after the change in positions due to GP test run.
    Also the FundsIn into different test FSPs have been removed as that is not needed anymore.
    As part of this task, I have noticed the noresponsepayeefsp is showing up a position increase which should not be the case as this fsp is specifically used in transfers error cases, where the transfers fail and no change in positions. Below issue is created to look deeper into the issue:
    GoldenPath test for the noresponsepayeefsp is not supposed to carry any position #3170

mdebarros added a commit to mojaloop/helm that referenced this issue Mar 22, 2023
@mdebarros
feat(mojaloop/##3165): pre cleanup and post clean up scripts failing …
346e9d9 
…when tested on mojaloop helm v15 release

feat(mojaloop/##3165): pre cleanup and post clean up scripts failing when tested on mojaloop helm v15 release - mojaloop/project#3165
- Updated Test Case Collection v15.0.0-snapshot.7
- Added new Helm test 'ml-ttk-test-cleanup'
- Updated weight of test-cases to accomodate 'ml-ttk-test-cleanup'
@mdebarros mdebarros mentioned this issue Mar 22, 2023
Merged
@mdebarros
Copy link
Member

PR for Helm to include POST Cleanup Helm Test: mojaloop/helm#557

mdebarros pushed a commit to mojaloop/testing-toolkit-test-cases that referenced this issue Mar 23, 2023
@sri-miriyala
feat(mojaloop/#3165): Remove settlement clean up from GP (#117)
ad1a284 
feat(mojaloop/#3165): Remove settlement clean up from GP (#117) - mojaloop/project#3165
- Removed the set of running settlement before and after GP collection. This settlement run is an independent collection that can be run on a needed basis.
- Added a new `hub/cleanup` folder, with position reset script
@mdebarros mdebarros self-assigned this Mar 23, 2023
mdebarros added a commit to mojaloop/helm that referenced this issue Mar 23, 2023
@mdebarros
feat(mojaloop/#3165): post clean up scripts (#557)
2d81622 
feat(mojaloop/#3165): post clean up scripts failing when tested on mojaloop helm v15 release - mojaloop/project#3165
- Updated Test Case Collection v15.0.0-snapshot.7
- Added new Helm test 'ml-ttk-test-cleanup'
- Updated weight of test-cases to accomodate 'ml-ttk-test-cleanup'
- Updated release notes with issue
- Updated readme with new post "cleanup" test-case.
vijayg10 pushed a commit to mojaloop/testing-toolkit-test-cases that referenced this issue May 23, 2023
@sri-miriyala
feat(mojaloop/#3165): Remove settlement clean up from GP (#117)
b059a56 
feat(mojaloop/#3165): Remove settlement clean up from GP (#117) - mojaloop/project#3165
- Removed the set of running settlement before and after GP collection. This settlement run is an independent collection that can be run on a needed basis.
- Added a new `hub/cleanup` folder, with position reset script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdebarros mdebarros

@sri-miriyala sri-miriyala

Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service core-dev-squad oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@elnyry-sam-k @mdebarros @sri-miriyala @PaulGregoryBaker @chris-me-law