fix(mojaloop/#2535): fspiop api version negotiation not handled by quoting service (#289) #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mdebarros
commented
Nov 15, 2021
mdebarros
commented
- fix(mojaloop/#2535): fspiop api version negotiation not handled by quoting service - FSPIOP API version negotiation not handled - Quoting-Service project#2535
- general fixes for quoting-service changes
- fixed unit tests to correctly load config
…ansfers service - updated dependencies - add 'json-rules-engine' and 'eslint' to ncurc.json ignore file as they have breaking changes - fixed audit-resolve issues - added fixes for api negotiation validation - re-factored outgoing messages by using the in-line config - fixed unit tests BREAKING CHANGE: Forcing a major version change for awareness of the config changes. The `LIB_RESOURCE_VERSIONS` env var is now deprecated, and this is now also controlled by the PROTOCOL_VERSIONS config in the default.json. This has been done for consistency between all API services going forward and unifies the config for both inbound and outbound Protocol API validation/transformation features.
…LIDATELIST - QUOTE_PROTOCOL_VERSIONS__ACCEPT__VALIDATELIST can be set as follows "[ \"1\", \"1.1\"]" and it will be parsed correctly into a object
…I-version-negotiation-not-handled---Transfers-service
…oting service (mojaloop#289) - fix(mojaloop/#2535): fspiop api version negotiation not handled by quoting service - mojaloop/project#2535 - general fixes for quoting-service changes
mdebarros
requested review from
elnyry-sam-k,
lewisdaly,
oderayi,
shashi165,
vgenev and
vijayg10
as code owners
elnyry-sam-k
approved these changes
Nov 16, 2021
lewisdaly
approved these changes
Nov 16, 2021
This was referenced Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.