Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: added outbound bulk api #320

Merged
merged 15 commits into from
Jun 17, 2022
Merged

feat!: added outbound bulk api #320

merged 15 commits into from
Jun 17, 2022

Conversation

shashi165
Copy link
Contributor

@shashi165 shashi165 commented May 30, 2022 •
edited

BREAKING CHANGE:
The bulk transfers api has been re-defined, hence old bulkTransfers requests won't work anymore

@shashi165 shashi165 self-assigned this May 30, 2022
@shashi165 shashi165 requested a review from kirgene as a code owner May 30, 2022 20:52
PaulGregoryBaker
PaulGregoryBaker reviewed Jun 1, 2022
View reviewed changes
Copy link

@PaulGregoryBaker PaulGregoryBaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PATCH need to change to a PUT.

Sam raised the point that only Mojaloop can raise a Patch notification, and Patch should be a notification and not change or affect anything at the switch.

elnyry-sam-k
elnyry-sam-k previously approved these changes Jun 6, 2022
View reviewed changes
mdebarros
mdebarros reviewed Jun 8, 2022
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me based on the latest design.

However, is this API definition not generated from API snippets?

src/OutboundServer/api.yaml Outdated Show resolved Hide resolved
@elnyry-sam-k
Copy link
Member

@shashi165 - can you also please change the version to 2.0.0 - this being a major change because of new resource addition

mdebarros
mdebarros requested changes Jun 17, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/OutboundServer/api.yaml Show resolved Hide resolved
@shashi165 shashi165 changed the title feat: added outbound bulk api feat!: added outbound bulk api Jun 17, 2022
@shashi165 shashi165 requested a review from mdebarros June 17, 2022 14:24
mdebarros
mdebarros approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@shashi165 shashi165 merged commit e2e83e9 into master Jun 17, 2022
@shashi165 shashi165 deleted the mbp355 branch June 17, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdebarros mdebarros mdebarros approved these changes

@kirgene kirgene Awaiting requested review from kirgene

@PaulGregoryBaker PaulGregoryBaker Awaiting requested review from PaulGregoryBaker

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k elnyry-sam-k is a code owner

Assignees

@shashi165 shashi165

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shashi165 @elnyry-sam-k @mdebarros @PaulGregoryBaker