Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mojaloop/#2092): upgrade nodeJS version for core services #168

Merged
merged 49 commits into from
May 9, 2022

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented Apr 26, 2022

  • updated dependencies
  • upgraded nodejs to latest lts for Upgrade "central-services-logger" to node v16 (LTS) project#2745
    • added .nvmrc
    • updated circleci config
  • updated ci-cd for automated release
  • updated ci-cd ubuntu image to the latest available
  • fixed auto-commit messages on CI-CD release to correctly reference the mojaloop/issue repo by adding a standard-release override to the package.json
  • re-structured project code to align to core Mojaloop repositories to enable sharing of the circleci configuration to run standard CI-CD flows
  • fixed unit test paths to reflect the project re-structuring
  • added test-lint to CI-CD flows
  • added test-dependencies to CI-CD flows
  • added slack messages to GH, NPM publish jobs with appropriate error messages. We can now track GH and NPM jobs independently via slack as a result. Previously only GH releases would be announced, with the NPM release potentially being "swallowed" until someone noticed.
  • added snapshot script to package.json. This will auto-bump the npm version with snapshot.# and commit both the package/package-lock files. Super useful for working with snapshot releases. This will also create an associated snapshot tag, and all the developer would need to do is push that tag for the snapshot build to be released. This can be done from any branch.
  • updated CircleCI Orb for Slack notifications to the latest version using standard templates: https://github.com/mojaloop/ci-config/tree/master/slack-templates

Notes:

BREAKING CHANGE: major version bump for node v16 LTS support, and re-structuring of project directories to align to core Mojaloop repositories!

- aligned ci-cd config
- added standard-version postchangelog script
- updated dependencies
- re-structured project to align to standard mojaloop project repositories. thereby allowing us to re-use CI-CD scripts without modification!
@mdebarros mdebarros marked this pull request as ready for review April 27, 2022 11:52
.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@elnyry-sam-k
Copy link
Member

Looking good Miguel, just one minor change from me.. Either mark the PR as breaking change "!" or upgrade package version to v17 or as relevant

@mdebarros
Copy link
Member Author

mdebarros commented Apr 27, 2022

Looking good Miguel, just one minor change from me.. Either mark the PR as breaking change "!" or upgrade the package version to v17 or as relevant

Hey @elnyry-sam-k , I have already marked this as breaking by adding the BREAKING_CHANGE into the commit message footer:

BREAKING CHANGE: ....

@mdebarros mdebarros self-assigned this Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants