Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changed the hardcoded fspIds to environment variables #50

Merged
merged 3 commits into from
Sep 16, 2021
Merged

fix: changed the hardcoded fspIds to environment variables #50

merged 3 commits into from
Sep 16, 2021

Conversation

vijayg10
Copy link
Contributor

No description provided.

@vijayg10 vijayg10 self-assigned this Sep 16, 2021
mdebarros
mdebarros previously approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

mdebarros
mdebarros previously approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mdebarros mdebarros changed the title Chnaged the hardcoded fspIds to environment variables Changed the hardcoded fspIds to environment variables Sep 16, 2021
@mdebarros mdebarros changed the title Changed the hardcoded fspIds to environment variables fix: changed the hardcoded fspIds to environment variables Sep 16, 2021
mdebarros
mdebarros approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@vijayg10 vijayg10 merged commit 25f4ced into mojaloop:master Sep 16, 2021
@vijayg10 vijayg10 deleted the feature/parameterize-fspids-in-provisioning branch September 16, 2021 17:10
@vijayg10 vijayg10 mentioned this pull request Sep 16, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdebarros mdebarros mdebarros approved these changes

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k

Assignees

@vijayg10 vijayg10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vijayg10 @mdebarros