Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mojaloop/#2719): post quotes fails when transactionid does not equal transactionrequestId #68

Merged
merged 1 commit into from
Mar 14, 2022
Merged

fix(mojaloop/#2719): post quotes fails when transactionid does not equal transactionrequestId #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 43 additions & 36 deletions collections/hub/golden_path/feature_tests/p2p_money_transfer/p2p_happy_path.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@
"meta": {
"info": "This is a happy path to test an end to end transfers. It includes party lookup, quote and transfer phases."
},
"fileInfo": {
"path": "hub/golden_path/feature_tests/p2p_money_transfer/p2p_happy_path.json",
"labels": [
"p2p"
]
},
"requests": [
{
"id": 1,
Expand Down Expand Up @@ -178,6 +184,7 @@
},
"url": "{$inputs.HOST_ACCOUNT_LOOKUP_SERVICE}",
"path": "/parties/{$inputs.toIdType}/{$inputs.toIdValue}",
"scriptingEngine": "javascript",
"scripts": {
"preRequest": {
"exec": [
Expand All @@ -193,8 +200,7 @@
"}"
]
}
},
"scriptingEngine": "javascript"
}
},
{
"id": 4,
Expand All @@ -221,6 +227,7 @@
"body": {
"quoteId": "{$function.generic.generateUUID}",
"transactionId": "{$function.generic.generateUUID}",
"transactionRequestId": "{$function.generic.generateUUID}",
"payer": {
"partyIdInfo": {
"partyIdType": "{$inputs.fromIdType}",
Expand Down Expand Up @@ -255,22 +262,6 @@
"note": "{$inputs.note}"
},
"scriptingEngine": "javascript",
"scripts": {
"preRequest": {
"exec": [
"if (environment.ENABLE_WS_ASSERTIONS===true) {",
" await websocket.connect(environment.PAYEEFSP_SDK_TESTAPI_WS_URL + '/requests/{$request.body.quoteId}', 'payeeRequest')",
"}"
]
},
"postRequest": {
"exec": [
"if (environment.ENABLE_WS_ASSERTIONS===true) {",
" environment.payeeRequest = await websocket.getMessage('payeeRequest', environment.WS_ASSERTION_TIMEOUT)",
"}"
]
}
},
"tests": {
"assertions": [
{
Expand Down Expand Up @@ -394,7 +385,23 @@
"ID": "{$inputs.toIdValue}"
},
"path": "/quotes",
"url": "{$inputs.HOST_QUOTING_SERVICE}"
"url": "{$inputs.HOST_QUOTING_SERVICE}",
"scripts": {
"preRequest": {
"exec": [
"if (environment.ENABLE_WS_ASSERTIONS===true) {",
" await websocket.connect(environment.PAYEEFSP_SDK_TESTAPI_WS_URL + '/requests/{$request.body.quoteId}', 'payeeRequest')",
"}"
]
},
"postRequest": {
"exec": [
"if (environment.ENABLE_WS_ASSERTIONS===true) {",
" environment.payeeRequest = await websocket.getMessage('payeeRequest', environment.WS_ASSERTION_TIMEOUT)",
"}"
]
}
}
},
{
"id": 5,
Expand Down Expand Up @@ -430,22 +437,6 @@
"condition": "{$prev.4.callback.body.condition}"
},
"scriptingEngine": "javascript",
"scripts": {
"preRequest": {
"exec": [
"if (environment.ENABLE_WS_ASSERTIONS===true) {",
" await websocket.connect(environment.PAYEEFSP_SDK_TESTAPI_WS_URL + '/requests/{$request.body.transferId}', 'payeeRequest')",
"}"
]
},
"postRequest": {
"exec": [
"if (environment.ENABLE_WS_ASSERTIONS===true) {",
" environment.payeeRequest = await websocket.getMessage('payeeRequest', environment.WS_ASSERTION_TIMEOUT)",
"}"
]
}
},
"tests": {
"assertions": [
{
Expand Down Expand Up @@ -550,7 +541,23 @@
}
]
},
"url": "{$inputs.HOST_ML_API_ADAPTER}"
"url": "{$inputs.HOST_ML_API_ADAPTER}",
"scripts": {
"preRequest": {
"exec": [
"if (environment.ENABLE_WS_ASSERTIONS===true) {",
" await websocket.connect(environment.PAYEEFSP_SDK_TESTAPI_WS_URL + '/requests/{$request.body.transferId}', 'payeeRequest')",
"}"
]
},
"postRequest": {
"exec": [
"if (environment.ENABLE_WS_ASSERTIONS===true) {",
" environment.payeeRequest = await websocket.getMessage('payeeRequest', environment.WS_ASSERTION_TIMEOUT)",
"}"
]
}
}
}
]
}
Expand Down