Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(mojaloop/#3521): nodejs upgrade #91

Merged
merged 23 commits into from
Sep 20, 2023
Merged

chore(mojaloop/#3521): nodejs upgrade #91

merged 23 commits into from
Sep 20, 2023

Conversation

oderayi
Copy link
Contributor

@oderayi oderayi commented Sep 14, 2023 •
edited

chore(mojaloop/#3521): NodeJS version upgrade - mojaloop/project#3521

  • Upgraded nodejs from v16 to v18 LTS
  • Applied CI changes as previously implemented in sdk-scheme-adapter
  • Updated NPM dependencies
  • Re-implement husky integration due to API changes in husky's latest version
  • Resolved all audit issues
  • Fixed docker-compose issues
  • Migrated master branch to main branch

@oderayi oderayi marked this pull request as ready for review September 15, 2023 10:46
@oderayi oderayi changed the title chore: nodejs upgrade chore(mojaloop/#3521): nodejs upgrade Sep 15, 2023
@oderayi oderayi mentioned this pull request Sep 15, 2023
Closed
14 tasks
vijayg10
vijayg10 reviewed Sep 19, 2023
View reviewed changes
audit-ci.jsonc Outdated Show resolved Hide resolved
vijayg10
vijayg10 reviewed Sep 19, 2023
View reviewed changes
Copy link

@vijayg10 vijayg10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added a comment, otherwise LGTM

@oderayi oderayi merged commit 0e7c958 into mojaloop:main Sep 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijayg10 vijayg10 vijayg10 approved these changes

@kleyow kleyow Awaiting requested review from kleyow kleyow is a code owner

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k elnyry-sam-k is a code owner

@lewisdaly lewisdaly Awaiting requested review from lewisdaly lewisdaly is a code owner

@mdebarros mdebarros Awaiting requested review from mdebarros mdebarros is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oderayi @vijayg10