Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normal format (transformed) PNGs are fuzzy and muted #4

Closed
nvkelso opened this issue Jun 22, 2017 · 8 comments
Closed

Normal format (transformed) PNGs are fuzzy and muted #4

nvkelso opened this issue Jun 22, 2017 · 8 comments
Assignees
Labels

Comments

@nvkelso
Copy link
Collaborator

nvkelso commented Jun 22, 2017

Ported from hotosm/oam-dynamic-tiler#39.

Looks like MarbleTiler fork is producing different normals than Joerd. There are probably more than one way of calculating these, but the output of Joerd is better for presentation cartography like Walkabout style and MarbleTiler should better match that output.

Specifically, MarbleTiler dev (top again) seems to have less exaggeration on the terrain / less details (compared to joerd prod)? Is the kernel size larger in MarbleTiler versus Joerd? That may account for more generalized looking relief.

Example 1:

dev-22 marbletiler fuzzy, less exaggeration
prod-22 joerd crispier (more detail), more exaggeration

Example 2:

dev-395 marbletiler
prod-395 joerd

Walkabout showing Example 2:

marbletiler pasted image at 2017_06_06 10_27 pm
joerd pasted image at 2017_06_06 10_27 pm 1

@iandees
Copy link
Collaborator

iandees commented Jun 22, 2017

For a more recent reference, here is output from the lambda tiler now:

url
image

@nvkelso
Copy link
Collaborator Author

nvkelso commented Jun 22, 2017

This is still a problem. I suspect it's compounded by not having consistent exaggeration applied in #3 (as in first that one first, retest), but I suspect there are some data differences, too.

@iandees
Copy link
Collaborator

iandees commented Jul 5, 2017

An anecdote: I took the URL from my comment above and added @2x to bump the resolution. Then I copied that 512x512 pixel image into an image manipulation program and sized it back down to 256x256 pixels I get this:

image

That image looks to be crisp like @nvkelso's image in the description of this bug. I wonder if this is a problem related to resolution?

@mojodna
Copy link
Owner

mojodna commented Jul 11, 2017

It is indeed resolution-related (and a side-effect of trying to use resolution for everything internally rather than target zoom as distinct from target output size). The 1x-scaled version only uses etopo1/ETOPO1_Bed_g.tif, the 2x-scaled version uses gmted/30N180W_20101117_gmted_mea075.tif, gmted/30N000E_20101117_gmted_mea075.tif.

The fix for this is to bump min_zoom for GMTED down by 1 (and possibly for all other sources). (It's currently 7 for these particular files; some GMTED sources are 5 (southern polar regions).)

I'll let @iandees do the honors.

@mojodna mojodna assigned iandees and unassigned mojodna Jul 11, 2017
@nvkelso
Copy link
Collaborator Author

nvkelso commented Jul 11, 2017

Let's verify this by running the following on all rows in the footprints database:

update footprints set min_zoom = greater(0, min_zoom - 1)

Once verified via an updated Lambda tiler, we should followup on #12 and modify https://github.com/mojodna/marblecutter/blob/master/bin/ingest_single_footprint.sh#L48 to show:

min_zoom=approximate_zoom - 4,

The different content in a 256px versus 512px tile goes against the grain of what we've done for vector tiles but I see your point for raster.

@iandees
Copy link
Collaborator

iandees commented Jul 12, 2017

Ran the SQL:

footprints=> update footprints set min_zoom = greatest(0, min_zoom - 1);
UPDATE 580635

@iandees
Copy link
Collaborator

iandees commented Jul 12, 2017

Re-running the tile in question after the min_zoom change:

image

The imagery sources used:

gmted/30N180W_20101117_gmted_mea075.tif, gmted/30N000E_20101117_gmted_mea075.tif

@nvkelso
Copy link
Collaborator Author

nvkelso commented Jul 13, 2017

Fixed! Verified in Seth's Lambda tiler.

@nvkelso nvkelso closed this as completed Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants