-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normal format (transformed) PNGs are fuzzy and muted #4
Comments
For a more recent reference, here is output from the lambda tiler now: |
This is still a problem. I suspect it's compounded by not having consistent exaggeration applied in #3 (as in first that one first, retest), but I suspect there are some data differences, too. |
An anecdote: I took the URL from my comment above and added That image looks to be crisp like @nvkelso's image in the description of this bug. I wonder if this is a problem related to resolution? |
It is indeed resolution-related (and a side-effect of trying to use resolution for everything internally rather than target zoom as distinct from target output size). The 1x-scaled version only uses The fix for this is to bump I'll let @iandees do the honors. |
Let's verify this by running the following on all rows in the footprints database:
Once verified via an updated Lambda tiler, we should followup on #12 and modify https://github.com/mojodna/marblecutter/blob/master/bin/ingest_single_footprint.sh#L48 to show:
The different content in a 256px versus 512px tile goes against the grain of what we've done for vector tiles but I see your point for raster. |
Ran the SQL:
|
Fixed! Verified in Seth's Lambda tiler. |
Ported from hotosm/oam-dynamic-tiler#39.
Looks like MarbleTiler fork is producing different normals than Joerd. There are probably more than one way of calculating these, but the output of Joerd is better for presentation cartography like Walkabout style and MarbleTiler should better match that output.
Specifically, MarbleTiler dev (top again) seems to have less exaggeration on the terrain / less details (compared to joerd prod)? Is the kernel size larger in MarbleTiler versus Joerd? That may account for more generalized looking relief.
Example 1:
marbletiler
fuzzy, less exaggerationjoerd
crispier (more detail), more exaggerationExample 2:
marbletiler
joerd
Walkabout showing Example 2:
marbletiler
joerd
The text was updated successfully, but these errors were encountered: