Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linkcheck doesn't work - links never checked #124

Closed
hussam-qasem opened this issue Apr 8, 2023 · 5 comments
Closed

linkcheck doesn't work - links never checked #124

hussam-qasem opened this issue Apr 8, 2023 · 5 comments

Comments

@hussam-qasem
Copy link

  • Mojolicious version: 9.31
  • Minion version: 10.25
  • Perl version: v5.36.0
  • Operating system: macOS 12.6.3 (21G419)

Steps to reproduce the behavior

  1. Start a Postgres Database
docker run --rm --name postgres -e POSTGRES_HOST_AUTH_METHOD=trust -p 5432:5432 postgres:15.2
  1. start linkcheck Mojo App.
git clone https://github.com/mojolicious/minion/
cd minion/examples/linkcheck/
morbo script/linkcheck
  1. Check the default URL (POST)
curl -X POST -F url=https://mojolicious.org/perldoc http://127.0.0.1:3000/links
  1. Wait for results (GET)
for i in $(seq 1 10); do curl http://localhost:3000/links/1; sleep 3; done

Expected behavior

Result should return

Actual behavior

Result never returned. LinkCheck::Task::CheckLinks::_check_links never called.

Test fails

TEST_ONLINE=postgresql://postgres@127.0.0.1:5432/postgres script/linkcheck test

Unknown command "test", maybe you need to install it?
@hussam-qasem hussam-qasem changed the title linkcheck doesn't work linkcheck doesn't work - links never checked Apr 8, 2023
@hussam-qasem
Copy link
Author

I am sorry. I forgot to run a worker:

perl script/linkcheck minion worker

In docker environment, should the worker be running in a separate container though?

@kraih kraih closed this as completed Apr 8, 2023
@kraih kraih reopened this Apr 8, 2023
@kraih kraih closed this as completed Apr 8, 2023
@kraih
Copy link
Member

kraih commented Apr 8, 2023

In docker environment, should the worker be running in a separate container though?

Yes.

@hussam-qasem
Copy link
Author

Thank you @kraih for the prompt response. I'm still unable to run the tests though:

TEST_ONLINE=postgresql://postgres@127.0.0.1:5432/postgres script/linkcheck test

@kraih
Copy link
Member

kraih commented Apr 10, 2023

...script/linkcheck test

I have no idea what that is.

@hussam-qasem
Copy link
Author

...script/linkcheck test

I have no idea what that is.

From the test file. I thought it was possible, other than prove -lv. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants