increase the performance gain to 60% for lower log levels

mojolicious · Nov 8, 2018 · be201fa · be201fa
1 parent 11625c0
commit be201fa
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/lib/Mojo/Log.pm b/lib/Mojo/Log.pm
@@ -37,10 +37,10 @@ sub append {
   flock $handle, LOCK_UN;
 }
 
-sub debug { $_[0]->is_level('debug') ? _log(@_, 'debug') : $_[0] }
-sub error { $_[0]->is_level('error') ? _log(@_, 'error') : $_[0] }
-sub fatal { $_[0]->is_level('fatal') ? _log(@_, 'fatal') : $_[0] }
-sub info  { $_[0]->is_level('info')  ? _log(@_, 'info')  : $_[0] }
+sub debug { 1 >= $LEVEL{$_[0]->level} ? _log(@_, 'debug') : $_[0] }
+sub error { 4 >= $LEVEL{$_[0]->level} ? _log(@_, 'error') : $_[0] }
+sub fatal { 5 >= $LEVEL{$_[0]->level} ? _log(@_, 'fatal') : $_[0] }
+sub info  { 2 >= $LEVEL{$_[0]->level} ? _log(@_, 'info')  : $_[0] }
 
 sub is_level { $LEVEL{pop()} >= $LEVEL{shift->level} }
 
@@ -50,7 +50,7 @@ sub new {
   return $self;
 }
 
-sub warn { $_[0]->is_level('warn') ? _log(@_, 'warn') : $_[0] }
+sub warn { 3 >= $LEVEL{$_[0]->level} ? _log(@_, 'warn') : $_[0] }
 
 sub _default {
   my ($time, $level) = (shift, shift);