Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update room object #14

Open
malakada opened this issue Jan 9, 2015 · 0 comments
Open

Update room object #14

malakada opened this issue Jan 9, 2015 · 0 comments

Comments

@malakada
Copy link

malakada commented Jan 9, 2015

The room object returned by Candy.Core.getRoom(roomJid) is incomplete. It's missing:

  • a way to get to the DOM pane element
  • the information from Candy.View.Pane.Chat.rooms[roomJid]:
    • enableScroll: false
    • id: "068b38b88f05b8304d9c6dfb06ac2e21"
    • mentionsCount: 0
    • messageCount: 4
    • name: "thing"
    • scrollPosition: -1
    • targetJid: "thing@conference.powerhrg.com"
    • type: "groupchat"
    • user: Candy.Core.ChatUser
    • usercount: 1

Related triggerHandler PRs:

Of the above list, PRs 12, 13, 15, 17, 18, and 19 are probably the most relevant as they need information from the Chatroom object that it doesn't currently provide.

This is where the room object is first created: https://github.com/mojolingo/candy/blob/dev/src/view/pane/room.js#L76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant