Ruby 1.9 MonitorMixin::ConditionVariable#wait timeout not supported

[geoffgarside]

Seems that presently the timeout parameter to the MonitorMixin::ConditionVariable#wait method is not supported in Ruby 1.9. This is currently used in lib/god/driver.rb:88. I'm not sure if the timeout used at this point in god is required or if its just adding a back-off so that the event isn't retried too quickly. It might be worth checking to see if god is being invoked by ruby 1.9 and then setting the delay to nil on that case.

[geoffgarside]

I think I might have fixed this in my fork, but I can't get the unit tests to run to completion under Ruby 1.9 either with or without my changes.

[eric]

I've done a little to get the ConditionVariable working by grabbing code from the latest 1.9 changes:

http://github.com/eric/god/tree/condition-variable-1.9-support

[julian7]

I gave it a shot, and it seems to be working well on my laptop (osx, rvm, ruby 1.9.1). I'll let it run overnight on a server, let's see whether it works (freebsd, ruby 1.9.1 from ports).

[eric]

This is the same issue as #6.

[sometimesfood]

Your fixes for Ruby 1.9 seem to work nicely here (Debian Lenny, Ruby 1.9.0).

Is there anything specific you'd like to have tested that we can help with?

[mojombo]

Dupe of #6. The monitor patches are in 0.9.0.

[julian7]

Thanks for the update. You may close this issue.