Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid tar file on windows #26

Closed
mjalil opened this issue Aug 25, 2010 · 0 comments
Closed

Invalid tar file on windows #26

mjalil opened this issue Aug 25, 2010 · 0 comments

Comments

@mjalil
Copy link

mjalil commented Aug 25, 2010

I use Redmine and its plugin gitrevision-download on Microsoft Windows.
tar files that the plugin generates have 2 problems that relate to Grit:

  1. Invalid tar file:
    Grit uses win32-open3 on windows and respect to the README of win32-open3 the default mode of output is 't' (i.e. text mode)
    This leads to invalid tar files. output mode should be set to 'b' . in order to this we should call Open3.popen3(command, 'b') in windows
  2. Extra ' prepended to file names:
    Also transform_options uses single quotations .e.g. --prefix='pre fix/' that leads to an extra ' prepended to file names e.g. 'pre fix/'my source.cs

I have forked and pushed a patch to Grit and Currently the issue is solved in my working copy

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant