Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The once_cell dependency should be optional #427

Closed
tatsuya6502 opened this issue May 31, 2024 · 0 comments · Fixed by #444
Closed

The once_cell dependency should be optional #427

tatsuya6502 opened this issue May 31, 2024 · 0 comments · Fixed by #444
Milestone

Comments

@tatsuya6502
Copy link
Member

As of moka@v0.12.7, once_cell dependency in Cargo.toml does not have optional = true. However, we removed the global thread pool from moka@v0.12.0 so we do not need once_cell in the most of the time.

We need once_cell only for the followings:

  • some unit tests → should be a dev-dependencies.
  • the unstable-debug-counters feature → should have optional = true.
@tatsuya6502 tatsuya6502 changed the title Make once_cell dependency optional The once_cell dependency should be optional May 31, 2024
@tatsuya6502 tatsuya6502 added this to the v0.12.9 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant