Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default apiV3 page size is incorrect #8976

Closed
connoratrug opened this issue May 13, 2020 · 1 comment
Closed

Default apiV3 page size is incorrect #8976

connoratrug opened this issue May 13, 2020 · 1 comment
Assignees
@tommydeboer
Labels
8.3 bug mod:api-data

Comments

@connoratrug
Copy link
Contributor

How to Reproduce

Send request to data ( or meta data ) V3 without a page size query param

Expected behavior

returns results with a page size of 20 as per spec

molgenis/docs/data/metadata-api-v3.yaml

Line 348 in a23d577

default: 20

Observed behavior

returns results with a page size of 100
@connoratrug
Copy link
Contributor Author

Would like to submit a fix PR, but not sure if spec or impl is incorrect

@tommydeboer tommydeboer self-assigned this May 18, 2020
@fdlk fdlk closed this as completed in ad63870 May 18, 2020
fdlk added a commit that referenced this issue May 18, 2020
@fdlk
Merge pull request #8984 from tommydeboer/fix/metadata-api-spec
26b1ef6 
Fix #8976 Default apiV3 page size is incorrect
@fdlk fdlk added the 8.3 label May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tommydeboer tommydeboer

Labels
8.3 bug mod:api-data
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fdlk @tommydeboer @connoratrug